Skip to content

[css-ui-4][css-sizing] Moving box-sizing to the right spec #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frivoal opened this issue Oct 25, 2017 · 3 comments
Closed

[css-ui-4][css-sizing] Moving box-sizing to the right spec #1906

frivoal opened this issue Oct 25, 2017 · 3 comments

Comments

@frivoal
Copy link
Collaborator

frivoal commented Oct 25, 2017

CSS-UI has a section defining box-sizing. It's in this spec because we expected CSS-UI-3 to be the first to reach REC. Now that we're resolved to take it to PR, that part of the plan is mostly complete. But box-sizing does not really belong in there.

Moreover, it is currently written as a monkey-patch over the relevant sections of CSS2.1, which is really hard to read (and easy to overlook when reading 2.1).

We should probably move the relevant sections of 2.1 to css-sizing, with the box-sizing patch applied, maybe with some modernizing of the terminology (some adjustments might be in order to keep up with the more precise terminology we use these days, or to take the new vocabulary introduced by writing modes / logical properties into account as well).

Once that's done, CSS-UI-4 can just keep a stub pointing people who got there via a permalink to the new home of that property.

@tabatkins
Copy link
Member

I'm fine with this. @fantasai, any objections?

@tantek
Copy link
Member

tantek commented Nov 6, 2017

Also fine with this.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Move box-sizing to Sizing, and agreed to the following resolutions:

  • RESOLVED: Move the box-sizing property from UI 4 to Sizing.
The full IRC log of that discussion <TabAtkins> Topic: Move box-sizing to Sizing
<florian> https://github.com//issues/1906
<tantek> github: https://github.com//issues/1906
<TabAtkins> florian: Width and height are defined in 2.1. Box-sizing is defined in UI as a monkey-patch on that.
<TabAtkins> florian: Works, but is ugly.
<TabAtkins> florian: Now that UI is getting to Rec, it's about time we get that into a spec of its own.
<TabAtkins> florian: So we should take what's in 2.1, apply the box-sizing patch, and put it into a spec, probably Sizing.
<TabAtkins> florian: Also need ot make sure it work for logical/etc.
<TabAtkins> florian: So Sizing 4 looks like a good place to have it.
<TabAtkins> Rossen: This is in UI3, already tested, right?
<tantek> Yes
<TabAtkins> [Ian Kilpatrick wins CSS Bingo]
<TabAtkins> florian: Right, it's in UI3, and staying there as it goes to Rec. It's only in there, tho, because 15 years ago we thought UI would be the first to hit Rec. Turns out to have been true, but there are better places for it.
<TabAtkins> fantasai: Happy to pull in the monkey patch, hesitant to pull in all of 2.1...
<fantasai> >_<
<TabAtkins> Rossen: No need to dive into details, just about moving box-sizing from UI4 to Sizing.
<TabAtkins> RESOLVED: Move the box-sizing property from UI 4 to Sizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants