[css-fonts-4] font-variation-settings and font-feature-settings what should be returned for getComputedValue #1959
Assignees
Labels
Closed Accepted by CSSWG Resolution
Commenter Satisfied
Commenter has indicated satisfaction with the resolution / edits.
css-fonts-3
css-fonts-4
Current Work
Comments
|
WebKit's internal implementation of these settings is a map, which automatically removes duplicates. Purposely adding in duplicates just for the purpose of getComputedStyle() seems like a waste of memory. Other browsers will have to handle duplication anyway both for animation as well as for the text engine (because an instantiated font can only be drawn at a single position in the variation space). Therefore, they should just hold this de-duped data structure as their internal implementation. |
|
just discussed in CSS WG meeting |
|
RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) |
|
Added a test for feature settings, same results as above. @litherum I think that this should be added to the spec since 3/4 browsers do the opposite of what we resolved on. |
|
@gregwhitworth could you refactor that jsbin into a couple of WPT tests? One for font-variation-settings with rel=Help set to css fonts 4, and one for font-feature-settings with rel=help set to css fonts 3. I will review them. |
|
@svgeesus sure thing - assigned to myself |
|
@gregwhitworth please ping me when you have tests ready to review. Alternately, if you want me to take a crack at converting them, let me know. |
svgeesus
added a commit
that referenced
this issue
Jan 26, 2018
|
@svgeesus ok done - it is linked to this thread |
litherum
pushed a commit
that referenced
this issue
Mar 6, 2018
…should be returned for getComputedValue #1959
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 19, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT teststo use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 19, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT teststo use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 23, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 25, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 25, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 25, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jun 26, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jul 7, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jul 8, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jul 9, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786564}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jul 9, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786564}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this issue
Jul 9, 2020
Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786564}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jul 10, 2020
…ings when computing style., a=testonly Automatic update from web-platform-tests Deduplicate and sort font-variation-settings when computing style. Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786564} -- wpt-commits: 80883e4b131fc9d75959417deadcceba1bce1b59 wpt-pr: 24246
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this issue
Jul 10, 2020
…ings when computing style., a=testonly Automatic update from web-platform-tests Deduplicate and sort font-variation-settings when computing style. Make interpolation type always run CSSValues through the converter for this property. Update remaining WPT tests to use order-invariant comparison (as most tests for this property already use). spec https://drafts.csswg.org/css-fonts-4/#font-variation-settings-def If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property. resolution w3c/csswg-drafts#1959 RESOLVED: For both font-variation-settings and font-feature-settings, the computed value is a map (and thus specified dupes are removed) Bug: 1005355 Change-Id: I2f6f0f76fdcd69cfece283625cf42f517686dc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253248 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786564} -- wpt-commits: 80883e4b131fc9d75959417deadcceba1bce1b59 wpt-pr: 24246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is a testcase that we've seen interop issues with: http://jsbin.com/zenosupeke/edit?html,css,output
The specification doesn't state what should be returned, it would be good if we could get agreement on what should be returned.
The text was updated successfully, but these errors were encountered: