Skip to content

[css-align] justify-items synxtax doesn't allow 'overflow [leff | right]' #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javifernandez opened this issue Jan 16, 2018 · 4 comments
Closed

Comments

@javifernandez
Copy link
Contributor

After soe changes, due to ambiguities with the place-self and place-items shorthands, it was decided to restrict the position of the overflow-alignment values. That's fine. However, I'm not sure the current syntax for the justify-items is the one we were looking for:

https://drafts.csswg.org/css-align-3/#propdef-justify-items

| normal | stretch | <baseline-position> | [ <overflow-position>? <self-position> ] | [ legacy || [ left | right | center ] ]

If I understood it correctly, the syntax above parses as invalid CSS declarations like 'overflow leff'. As a matter of fact, overflow-positions is only valid if used with a self-position. However, the justify-self syntax parses as valid the combination with 'left' and 'right' as well.

Is this the intended behavior ?

@fantasai
Copy link
Collaborator

Looks indeed like an error in the grammar. Probably it should be

<overflow-position>? <self-position> |  legacy ||  <overflow-position>? [ left | right | center ]

@javifernandez
Copy link
Contributor Author

javifernandez commented Jan 18, 2018

Umm, the new proposed syntax allows "legacy safe left" and "unsafe right legacy" . Are we sure we want overflow-position in combination with 'legacy ? According to the specs, the 'legacy' keyword exists to implement the legacy alignment behavior of HTML’s <center> element and align attribute, so I don't think the overflow-position makes sense there.

@javifernandez
Copy link
Contributor Author

What abut this ?
<overflow-position>? [ <self-position> | left | right ] | legacy || [ left | right | center ]

@fantasai
Copy link
Collaborator

Fixed in 3e27468 ! Thanks~ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants