Skip to content

Test-suite, Ahem font #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobireif opened this issue Jan 18, 2018 · 5 comments
Closed

Test-suite, Ahem font #2200

tobireif opened this issue Jan 18, 2018 · 5 comments
Assignees

Comments

@tobireif
Copy link

tobireif commented Jan 18, 2018

I just was going through the test-suite, in three browsers, submitting results automatically and manually. Then I noticed ~"This test requires the Ahem font to be installed" - thus probably many test results were false.

Would it be possible to @font-face the Ahem font? (Everywhere, or for each test that requires it).

Then testing won't go wrong as it just did.

@gsnedders
Copy link
Member

FWIW, this would be better discussed on the w3c/web-platform-tests repository.

This has been discussed on several occasions before [citation needed], but I think we've always decided that it's simply too much effort to go through and add @font-face to every test case that uses it.

@frivoal
Copy link
Collaborator

frivoal commented Jan 19, 2018

@gsnedders That's understating it: the current policy is actually not to add @font-face for Ahem in new tests. I'd be happy to change that, but that's what it is for now, IIUC.

@liamquin
Copy link

liamquin commented Jan 19, 2018 via email

@tobireif
Copy link
Author

FWIW, this would be better discussed on the w3c/web-platform-tests repository.

Thanks for the info, next I'll try to remember to submit any issues there.

the current policy is actually not to add @font-face for Ahem

I'd prefer it if no test would require any specific font. But when a test writer has good reasons to require a specific font, then that font should be right there, without requiring the test-suite user to do anything regarding any required assets (fonts, images etc). @font-face is a great way to load the required font. When I supply test cases for issue reports I can't require the visitor to install the required font, so I make sure it's right there using @font-face, eg:

https://bugs.chromium.org/p/chromium/issues/detail?id=800693
->
https://tobireif.com/non_site_stuff/test_case_for_font_position_report/

I ran the CSS Grid test-suite, and I inadvertently supplied potentially-incorrect test results because the tests that require a specific font don't @font-face it. The note I then saw at a later point in time is not sufficient: I already had submitted hundreds of results (running the suite in 3 browsers) before I saw the note telling me to install a font on my machine, as if we are still in a time where @font-face didn't exist 😀

You can @font-face any respective required font(s) where necessary (or eg make sure that no existing or future test requires any fonts) - or you'll probably get even more incorrect test results by people who want to contribute by running the test suite, but aren't familiar with the implicit requirements that are only obvious among test-suite contributors, WG members, etc.

By the way, I'd be quite busy if every site required me to install a font, so I don't do that 😀 Supplying the font using @font-face is easy for future tests, and perhaps a script could ensure it for the existing ones. Or eg

the test harness JavaScript code [could] inject[...] @font-face for Ahem to every test[...]

@gsnedders
Copy link
Member

This issue was moved to web-platform-tests/wpt#9105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants