-
Notifications
You must be signed in to change notification settings - Fork 708
[css-align][css-multicol] Gutter properties computed value #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It seems to me that an author writing Based on that, I suggest that normal should compute to a width always. Your point about animation goes in the same direction. This is a technically breaking change for multicol, but I have a very hard time thinking of situations where that would have any negative impact. |
Right, probably. But then again, that argument only says why it is not necessary to make the change, not why it's a bad change. Transitioning from whatever it is right now (which may be normal) to a specified length sounds useful too, and normal not computing to a length gets in the way of that.
I don't follow. Why? Normal could mean "get the value of the parent" in subgrid, while still computing a a value (absolutized length if it's a length, or percentage if that's what you get from the parent). |
Having the computed value of one property depend on the computed values of other properties is problematic in general. In this case, it would depend on the computed values for I'd prefer to make |
ah, yes. I wasn't looking at the full picture, but that made sense. |
@MatsPalmgren Since we don't use gaps for block containers that aren't multicol, we could make it just depend on the |
The Working Group just discussed
The full IRC log of that discussion<dael> Topic: [css-align][css-multicol] Gutter properties computed value<dael> github: https://github.com//issues/2294 <dael> Rossen_: Summary is we have column gap normal value return as 0px for anything that's not a multi-column and 'normal' if it is a multicol <dael> Rossen_: Issue raised by Igalia that get computed style where all browsers but edge return normal. Proposal was to make computed value to be normal everywhere. <dael> Rossen_: The consensus on the issue seems to be normal computes as normal. <dael> Rossen_: So I'm looking for feedback or other idea. <dael> Rossen_: Should we just adopt proposed resolution or not change? <dael> Rossen_: Does anyone care about this who is on the call? <dael> tantek: Only thing I'd add is just +1 to Mats <dael> Rossen_: What he's saying is common sense of not making style depend on layout and not make properties depend on other properties which is one of our guiding rules and I fully agree. Just curious on this issue. <dael> rachelandrew: I agree with fantasai that people who care will specify anyway so if impl are happy to go with normal that makes sense. <dael> Rossen_: I don't think we'll have a problem changing to normal. I think we're the only impl that returns 0. I'm assuming given all other impl return normal there shouldn't be a compat risk for us, or at least minimal. <dael> tantek: Looking quick I didn't see a simple dom test to check current impl. I'd be curious to try it in other browsers to see if there is anything consensus-wise. <dael> Rossen_: Right. <dael> tantek: Can I request that before we resolve? To add a test to get information? <dael> Rossen_: Absolutely. We don't have to resolve today. fantasai and florian are out. They and Sergio are active. I'm just looking for progress. <dael> Rossen_: Sounds like we want examples and test cases to eval other impl. <dael> tantek: At least to informt he decision better. SOunds like rough consensus but it's based on theoretical purity. <dael> tantek: I'd like more concrete data. <rego> http://w3c-test.org/css/css-align/gaps/column-gap-parsing-001.html <dael> rego: THere's WPT tests for this. THat's why I realized Edge isn't returning normal and that's when I checked the specs. <dael> tantek: Can you add a link to it? <dael> rego: ^ <dael> tantek: Thanks. <tantek> rego which of the tests? <tantek> (of the 17) <rego> the first one "Default column-gap is 'normal'" <rego> in Edge it fails <rego> I meant, it returns 0px <dael> Rossen_: I see the same behavior as rego stated in the issue. In windows I see Edge report 0 and FF and Chrome return <dael> Rossen_: 'normal' <dael> tantek: There's 17 tests. <dael> rego: First one is the one that fails <dael> Rossen_: fwiw looking at IE I think we regressed this in edge unintentionally. <dael> Rossen_: For the sake of argument this could be jsut a bug. <dael> tantek: I see normal in FF & Chrome <rego> and Safari <dael> Rossen_: Yeah. That's what I said. Normal everywhere, FF, Chome IE 11. Edge is only one that does 0. <dael> tantek: Safari also. <dael> tantek: Okay. That makes it pretty clear. <dael> Rossen_: Going back to the issue, is this something we want to punt or do we feel there is enough understanding to resolve? <dael> tantek: I think there's enough understanding. <dael> tantek: If fantasai or anyone else has new information we can follow our normal proceedure. <dael> Rossen_: fantasai supports normal to normal in the issue. <dael> Rossen_: Objections to resolving that column-gap: normal computed value returns normal? <dael> RESOLVED: column-gap: normal computed value returns normal |
Matching the w3c/csswg-drafts#2294 spec change Not including tests for used value in multicol, because (so far) it is UA defined.
…ap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment)
…p' and 'grid-gap' alias the respective unprefixed properties. This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) Bug: 1398482 Reviewed-by: emilio
…p' and 'grid-gap' alias the respective unprefixed properties. This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) Bug: 1398482 Reviewed-by: emilio
…p' and 'grid-gap' alias the respective unprefixed properties. This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) Bug: 1398482 Reviewed-by: emilio
…p' and 'grid-gap' alias the respective unprefixed properties. This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) Bug: 1398482 Reviewed-by: emilio
…p' and 'grid-gap' alias the respective unprefixed properties. This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) Bug: 1398482 Reviewed-by: emilio
…ap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) UltraBlame original commit: ef9fa58539c0ab44cc1b85cb74902002417971b9
…ap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) UltraBlame original commit: ef9fa58539c0ab44cc1b85cb74902002417971b9
…ap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio This also makes 'normal' the initial value for the grid-* properties, per: w3c/csswg-drafts#2294 (comment) UltraBlame original commit: ef9fa58539c0ab44cc1b85cb74902002417971b9
These are the links to both specs:
In
css-align
it says:In
css-multicol
it says:I'm not sure if this difference is on purpose or not.
I understand that with the current text the computed value of
column-gap: normal
would be:0px
if it's not a multicol containernormal
if it's a multicol containerBut now that we're generalizing the properties to apply in other layout models (like grid and flexbox), it seems weird that we have a difference there.
Currently
getComputedStyle()
is returningnormal
in all browsers but Edge (where it returns0px
).I guess we could change this and we have 2 options:
normal
isnormal
.normal
is the used value.Note that if the computed style of
normal
isnormal
, then that value won't be animatable. However if it's the used value (0px
or1em
in multicol) then it'll be animatable.[ Edited by @dbaron to fix <production>s that were getting interpreted as HTML tags. ]
The text was updated successfully, but these errors were encountered: