Skip to content

[css-sizing] typos #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatsPalmgren opened this issue Feb 15, 2018 · 3 comments
Closed

[css-sizing] typos #2315

MatsPalmgren opened this issue Feb 15, 2018 · 3 comments

Comments

@MatsPalmgren
Copy link

https://drafts.csswg.org/css-sizing-3/#auto-box-sizes
in the first sentence: s/fromy/from/

https://drafts.csswg.org/css-sizing-3/#fit-content-block-size
in the first sentence: s/finite/definite/
These words have roughly the same meaning in CSS, but "definite" has a normative definition and the phrase "If the available space is definite" is used in multiple places elsewhere so I think it should be preferred.

https://drafts.csswg.org/css-sizing-3/#box-sizing

The box-sizing property switches the box model between asssigning finite sizes such as <length>s and <percentage>s ...

s/asssigning/assigning/
Maybe "finite" should be "definite" here too? If not, then "finite" is probably not the word to use here.

@donovanglover
Copy link
Contributor

I fixed the typos, but I personally find the third sentence confusing.

The box-sizing property switches the box model between assigning ... (implied and <verb>ing)

The word between implies that there are multiple things being talked about, i.e. "between assigning and <something else>".

@fantasai
Copy link
Collaborator

fantasai commented Mar 4, 2018

@MatsPalmgren OK, fixed typos and switched the last one to fixed.

@gloverdonovan Yes, you're right. I adjusted the wording, let me know if it still seems off? I've been staring at it a bit too long to know anymore.

@donovanglover
Copy link
Contributor

donovanglover commented Mar 5, 2018

Definitely better than before. I don't know enough about the spec to rewrite this sentence, but I'd personally change the last part from "the content box and the border box" to "the content box and border box values". What do you think?

Edit: Actually not sure if content box has a different meaning than content-box (same for border box and border-box), so I'm not sure if these changes would be valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants