-
Notifications
You must be signed in to change notification settings - Fork 713
[css-lists][cssom] Should the serialization of counter-reset/increment include default values? #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This should probably have the "css-list-3" label (can't seem to be allowed to add it) See initial Firefox-related discussion: https://bugzilla.mozilla.org/show_bug.cgi?id=1408257 Note: Newbie here, sorry if I used the wrong vocabulary above! |
Given the principle, I believe the default value should be omitted. We should add a web-platform test and file bugs to the corresponding browsers. |
Yeah, should be omitted unless there's web-compat to deal with. |
Fixed in 848b8c6 |
Marked "Obvious Bugfix" because we're supposed to stay in sync with 2.1. |
I don't see how that change addresses this issue. |
@ewilligers Yeah, I don't know why I posted that comment here. :/ Must've mixed up this issue with #4163. That said, I don't think any edits are needed here, so marking the issue closed. |
In the CSSOM general principles of serialization: https://drafts.csswg.org/cssom/#serializing-css-values
This would suggest that if a counter-reset or counter-increment was declared with no values, its serialization should not include the default value (resp. 0 or 1).
E.g.:
<body style="counter-increment: abc" onload="alert(document.body.style.counterIncrement)">
should display "abc".Edge 42 does this.
However Firefox 60, Chrome 66, and Safari 11.1 currently display "abc 1".
So, should the general rule be followed, or should there be a special case for counters? (Or something else?)
The text was updated successfully, but these errors were encountered: