-
Notifications
You must be signed in to change notification settings - Fork 715
[web-animations-1] Should setting the startTime of a play-pending animation to null
have side effects?
#2691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Apologies for the delay on this. @flackr and I talked it over this morning and option (a) - 'has no effect' makes most sense to us. We don't have a strong opinion on this however. Happy to discuss at the next monthly sync too. |
Interesting, I was actually leaning towards (b) since it gives author consistent behavior -- setting |
In which case something to discuss at our next sync I think! @graouts - any opinion? |
Discussed this yesterday with @graouts @stephenmcgruer @flackr and agreed that we should go with (b), i.e. no change to the spec. Part of the reasoning is that this not only makes it easy to synchronously pause without having to check the pending state, but it is also consistent with the fact that setting the Firefox will be updated in Mozilla bug 1478213 where I will also add a test for this. |
…n start time if we are pending; r=hiro As discussed here: w3c/csswg-drafts#2691 We have a similar check in SetCurrentTime (with the exception that, according to the spec, this behavior applies to either play OR pause pending, instead of just pause-pending) so this patch tries to match the comment and format of that check. Differential Revision: https://phabricator.services.mozilla.com/D2410 --HG-- extra : rebase_source : 519a976424b021203a369926344c2174662e6156
…n start time if we are pending; r=hiro As discussed here: w3c/csswg-drafts#2691 We have a similar check in SetCurrentTime (with the exception that, according to the spec, this behavior applies to either play OR pause pending, instead of just pause-pending) so this patch tries to match the comment and format of that check. Differential Revision: https://phabricator.services.mozilla.com/D2410
A test for this is added in: web-platform-tests/wpt#12195 |
…n start time if we are pending; r=hiro As discussed here: w3c/csswg-drafts#2691 We have a similar check in SetCurrentTime (with the exception that, according to the spec, this behavior applies to either play OR pause pending, instead of just pause-pending) so this patch tries to match the comment and format of that check. Differential Revision: https://phabricator.services.mozilla.com/D2410 UltraBlame original commit: e9fd7073981480be9893eda1590d1bdb9c764e24
…n start time if we are pending; r=hiro As discussed here: w3c/csswg-drafts#2691 We have a similar check in SetCurrentTime (with the exception that, according to the spec, this behavior applies to either play OR pause pending, instead of just pause-pending) so this patch tries to match the comment and format of that check. Differential Revision: https://phabricator.services.mozilla.com/D2410 UltraBlame original commit: e9fd7073981480be9893eda1590d1bdb9c764e24
…n start time if we are pending; r=hiro As discussed here: w3c/csswg-drafts#2691 We have a similar check in SetCurrentTime (with the exception that, according to the spec, this behavior applies to either play OR pause pending, instead of just pause-pending) so this patch tries to match the comment and format of that check. Differential Revision: https://phabricator.services.mozilla.com/D2410 UltraBlame original commit: e9fd7073981480be9893eda1590d1bdb9c764e24
Typically setting the start time of an animation should cancel any pending tasks. This provides applications with a way to synchronously seek/sync animations. Furthermore, by setting the start time to
null
applications can perform a synchronous pause.However, if an animation is play-pending its start time will already be unresolved (
null
).If the animation is play-pending when script sets the start time to
null
what should happen?a. The change is redundant and should be ignored. (Seems intuitive from a JS point of view, redundant changes have no side effects.), or
b. The pending play task is canceled. (Currently speced behavior. Allows applications to perform a synchronous pause even in the play-pending state.)
i.e.
(Firefox actually does (a) as an optimization but the spec says we should do (b) and I'm wondering which to fix.)
/cc @stephenmcgruer @flackr @graouts @dadaa
The text was updated successfully, but these errors were encountered: