-
Notifications
You must be signed in to change notification settings - Fork 717
[css-contain] Size contain shouldn't apply to tables #2746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah, I don't think it makes sense for it to apply to tables, because tables don't have a sensible way of being smaller than their contents. That's never been defined and it's not particularly clear what their contents would do (i.e., how wide to make each column). |
Oops, that sounds right, I don't quite see how it would work either. Sorry I phrased that wrong. Ping: @tabatkins @eaenet @mrego. I suspect you all agree, but just wanted to check before updating the spec. |
Yeah, sounds reasonable |
Agenda+ to confirm the proposed change. |
I can recall times when I've used tables with |
With table-layout:fixed, you can set the width of the table to less than its min-content width, so that sounds tempting, but:
So, I think we still need to exclude tables entirely, including when table-layout is fixed. |
Note that when we say "tables" here, we're referring to anything using |
Ya, I figured. :) |
Sounds good to me too. |
The Working Group just discussed
The full IRC log of that discussion<melanierichards> topic: Size contain shouldn't apply to tables<melanierichards> Github: https://github.com//issues/2746 <melanierichards> florian: we've already said that size containment doesn't apply to table parts, haven't said anything about tables. the way containment works, tables would end up smaller than their contents <melanierichards> Florian: in the inline axis of tables we don't have a good definition or interop. In block axis seems to do nothing. In inline axis, in some browsers the borders go diagonal <melanierichards> Florian: think we should skip this here <melanierichards> fantasai: I can imagine someone wanting to size constrain a table and put a scroller on it <melanierichards> Florian: proposal is to add tables to the list of things size containment doesn't apply to <melanierichards> Rossen: sounds reasonable <melanierichards> Rossen: objections? opinions? <melanierichards> [none] <melanierichards> RESOLVED: size containment doesn't apply to tables |
BTW, there's already a test currently checking the opposite thing: http://w3c-test.org/css/css-contain/contain-size-012.html I'll update the Chromium implementation and modify it. |
The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567289}
The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567289}
The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567289}
The test has been modified in web-platform-tests/wpt#11502. |
…or tables, a=testonly Automatic update from web-platform-tests[css-contain] Disable size containment for tables The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#567289} -- wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be wpt-pr: 11502
…or tables, a=testonly Automatic update from web-platform-tests[css-contain] Disable size containment for tables The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: Manuel Rego Casasnovas <regoigalia.com> Cr-Commit-Position: refs/heads/master{#567289} -- wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be wpt-pr: 11502 UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
…or tables, a=testonly Automatic update from web-platform-tests[css-contain] Disable size containment for tables The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: Manuel Rego Casasnovas <regoigalia.com> Cr-Commit-Position: refs/heads/master{#567289} -- wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be wpt-pr: 11502 UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
…or tables, a=testonly Automatic update from web-platform-tests[css-contain] Disable size containment for tables The CSSWG resolved about it in the last meeting: w3c/csswg-drafts#2746 BUG=843329 TEST=external/wpt/css/css-contain/contain-size-012.html Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4 Reviewed-on: https://chromium-review.googlesource.com/1100824 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: Manuel Rego Casasnovas <regoigalia.com> Cr-Commit-Position: refs/heads/master{#567289} -- wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be wpt-pr: 11502 UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
The section on size containment says size containment has no effect on internal table elements, however it seems like it also shouldn't apply to tables (which aren't internal table elements).
cc: @dbaron
The text was updated successfully, but these errors were encountered: