Skip to content

[css-contain] Size contain shouldn't apply to tables #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MReschenberg opened this issue Jun 6, 2018 · 12 comments
Closed

[css-contain] Size contain shouldn't apply to tables #2746

MReschenberg opened this issue Jun 6, 2018 · 12 comments

Comments

@MReschenberg
Copy link

The section on size containment says size containment has no effect on internal table elements, however it seems like it also shouldn't apply to tables (which aren't internal table elements).

cc: @dbaron

@dbaron
Copy link
Member

dbaron commented Jun 6, 2018

Yeah, I don't think it makes sense for it to apply to tables, because tables don't have a sensible way of being smaller than their contents. That's never been defined and it's not particularly clear what their contents would do (i.e., how wide to make each column).

@frivoal frivoal self-assigned this Jun 7, 2018
@frivoal
Copy link
Collaborator

frivoal commented Jun 7, 2018

Oops, that sounds right, I don't quite see how it would work either. Sorry I phrased that wrong.

Ping: @tabatkins @eaenet @mrego. I suspect you all agree, but just wanted to check before updating the spec.

@tabatkins
Copy link
Member

Yeah, sounds reasonable

@frivoal frivoal added the Agenda+ label Jun 7, 2018
@frivoal
Copy link
Collaborator

frivoal commented Jun 7, 2018

Agenda+ to confirm the proposed change.

@jonjohnjohnson
Copy link

I can recall times when I've used tables with table-layout: fixed and width not set to auto, where I'd be surprised to find out contain has no effect. Would this then force me to use a bunch of non-semantic divs with table structure display values? I'm primarily thinking of highly responsive layouts where I'm simulating element query behaviors, guessing I'd gain decent perf from using contain.

@frivoal
Copy link
Collaborator

frivoal commented Jun 7, 2018

With table-layout:fixed, you can set the width of the table to less than its min-content width, so that sounds tempting, but:

  • you still cannot set the height to less than the min-content height
  • what happens when the width is less than the min-content is not fully interoperable

So, I think we still need to exclude tables entirely, including when table-layout is fixed.

@MReschenberg MReschenberg changed the title [css-contain] SIze contain shouldn't apply to tables [css-contain] Size contain shouldn't apply to tables Jun 7, 2018
@tabatkins
Copy link
Member

Would this then force me to use a bunch of non-semantic divs with table structure display values?

Note that when we say "tables" here, we're referring to anything using display:table. So switching to <div style="display:table"> won't change anything.

@jonjohnjohnson
Copy link

Note that when we say "tables" here, we're referring to anything using display:table.

Ya, I figured. :)

@mrego
Copy link
Member

mrego commented Jun 7, 2018

Sounds good to me too.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Size contain shouldn't apply to tables, and agreed to the following:

  • RESOLVED: size containment doesn't apply to tables
The full IRC log of that discussion <melanierichards> topic: Size contain shouldn't apply to tables
<melanierichards> Github: https://github.com//issues/2746
<melanierichards> florian: we've already said that size containment doesn't apply to table parts, haven't said anything about tables. the way containment works, tables would end up smaller than their contents
<melanierichards> Florian: in the inline axis of tables we don't have a good definition or interop. In block axis seems to do nothing. In inline axis, in some browsers the borders go diagonal
<melanierichards> Florian: think we should skip this here
<melanierichards> fantasai: I can imagine someone wanting to size constrain a table and put a scroller on it
<melanierichards> Florian: proposal is to add tables to the list of things size containment doesn't apply to
<melanierichards> Rossen: sounds reasonable
<melanierichards> Rossen: objections? opinions?
<melanierichards> [none]
<melanierichards> RESOLVED: size containment doesn't apply to tables

@mrego
Copy link
Member

mrego commented Jun 14, 2018

BTW, there's already a test currently checking the opposite thing: http://w3c-test.org/css/css-contain/contain-size-012.html

I'll update the Chromium implementation and modify it.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 14, 2018
The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
mrego added a commit to mrego/csswg-drafts that referenced this issue Jun 14, 2018
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 14, 2018
The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567289}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 14, 2018
The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567289}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 14, 2018
The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567289}
@mrego
Copy link
Member

mrego commented Jun 14, 2018

The test has been modified in web-platform-tests/wpt#11502.

@mrego mrego removed the Needs Edits label Jun 14, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 11, 2018
…or tables, a=testonly

Automatic update from web-platform-tests[css-contain] Disable size containment for tables

The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567289}

--

wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be
wpt-pr: 11502
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…or tables, a=testonly

Automatic update from web-platform-tests[css-contain] Disable size containment for tables

The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstenshochromium.org>
Commit-Queue: Manuel Rego Casasnovas <regoigalia.com>
Cr-Commit-Position: refs/heads/master{#567289}

--

wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be
wpt-pr: 11502

UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…or tables, a=testonly

Automatic update from web-platform-tests[css-contain] Disable size containment for tables

The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstenshochromium.org>
Commit-Queue: Manuel Rego Casasnovas <regoigalia.com>
Cr-Commit-Position: refs/heads/master{#567289}

--

wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be
wpt-pr: 11502

UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…or tables, a=testonly

Automatic update from web-platform-tests[css-contain] Disable size containment for tables

The CSSWG resolved about it in the last meeting:
w3c/csswg-drafts#2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824
Reviewed-by: Morten Stenshorne <mstenshochromium.org>
Commit-Queue: Manuel Rego Casasnovas <regoigalia.com>
Cr-Commit-Position: refs/heads/master{#567289}

--

wpt-commits: d959a1e08444e4a134e446553ef19b2c5c1230be
wpt-pr: 11502

UltraBlame original commit: 369db514cec5ad6f39278d458b7da60d14ea9610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants