Skip to content

[css-align] [css-flexbox] [css-overflow] [css-rhythm] [css-shapes] [css-ui] Missing quotes around property refs #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tidoust opened this issue Jul 12, 2018 · 5 comments

Comments

@tidoust
Copy link
Member

tidoust commented Jul 12, 2018

According to the Value Definition Syntax, for "types that that have the same range of values as a property bearing the same name", "the type name is the property name (complete with quotes)".

If I'm reading the above syntax correctly, the quotes appear to be missing in a few property definitions and should be added in:

@tabatkins
Copy link
Member

tabatkins commented Jul 16, 2018

The markup is correct, this is a Bikeshed bug. I'll look into it.

@tabatkins
Copy link
Member

tabatkins commented Jul 16, 2018

I lied, this is a markup error. They're written in the source file as <'justify-items'>, when they should be <<'justify-items'>>, to get properly recognized as grammar non-terminals. In the absence of that they're just getting recognized as property/value links, with raw text < and > characters. (Luckily the single quotes prevent them from being parsed as start tags!)

fantasai added a commit that referenced this issue Aug 3, 2018
@fantasai
Copy link
Collaborator

fantasai commented Aug 3, 2018

Ok, I committed changes to fix all these. Couldn't figure out what error you were referring to for css-shapes-1/2, though?

Thanks for the report!!

@tidoust
Copy link
Member Author

tidoust commented Aug 6, 2018

Ok, I committed changes to fix all these.

Thanks!

Couldn't figure out what error you were referring to for css-shapes-1/2, though?

Both definitions reference the fill-rule property in SVG, so I would also expect to see <'fill-rule'>.

@astearns
Copy link
Member

fixed fill-rule with 81afc49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants