Skip to content

[css-backgrounds] Incorrect value dfn for border-color and background-clip #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tidoust opened this issue Jul 13, 2018 · 3 comments
Closed

Comments

@tidoust
Copy link
Member

tidoust commented Jul 13, 2018

The border-color definition seems to be using parentheses for grouping instead of brackets as described in Component value combinators. Correct value should be [<color>{1,4}]#.

Also, the "Value" header link is wrong, it should target https://drafts.csswg.org/css-backgrounds-4/#values as in all other property definition tables.

Similarly, I would expect to be able to parse the new values of background-clip using the usual Value Definition Syntax. For that to be possible, value should be text | border, and not text, border.

@tidoust
Copy link
Member Author

tidoust commented Jul 17, 2018

I don't want to make things unnecessarily complicated but something I had overlooked in this case is that the definition of background-clip is <box>#, and "New value" actually extends <box> (defined as border-box | padding-box | content-box), not the property itself.

In other words, the spec probably wants the final property to be defined as [ border-box | padding-box | content-box | text | border ] # and not as <box># | text | border, the latter being what a strict application of the rules would yield.

@tabatkins
Copy link
Member

Ah, indeed.

@tabatkins
Copy link
Member

Well, hm. I don't want to repeat the <box> values. I think what I want to do is redefine the property entirely to <bg-clip-value>#, and then define that to be <box> | border | text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants