-
Notifications
You must be signed in to change notification settings - Fork 711
[css-display] Parent box of run-in or non-principal box #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think we need to define that if Box A is made to be a direct child of box B, Box B is the parent of Box A. That's implied because we're assuming people understand the semantics of English. Is there something else I'm missing here? |
@fantasai I'm complaining that the definition is not clear. Frankly I'm not sure whether this "parent box" concept just refers to the parent (the graph theory concept) in the box tree? In that case I don't get why you are providing some kind of partial definition. It's confusing because it's looks like you are trying to define something different than the trivial concept, but it's not properly defined. And as you say, it's implied, so I would just remove it. If this is a different concept, the definition should state the difference clearly, like
|
The sentence you're quoting in the OP is there because otherwise we've defined that there's an element tree (which has parent-child relationships), and each element generates a box, but it's not otherwise defined how the boxes are related into a tree. The parent-child relationships of the boxes, in the general case, is not implied by anything else in the spec than this sentence. As for “I'm complaining that the definition is not clear”, what, specifically, is not clear? What alternative interpretation are you coming up with that isn't intended by the spec, and how is that supported by the spec? |
Well, it seems the definition is excluding element-generated non-principal boxes for some reason. And it's not clear whether this is intentional. Like if you have a
OK, it seems what you are trying to impose is
I would prefer something like that: it's not a concept definition but an instruction for the tree construction, and has no vague exception. Sure, it's still not completely detailed, but this can't be done in a single sentence. |
Aha. That's definitely an error. :)
Hm, that's a good one. I've rearranged some of the sentences and incorporated yours, it's now a separate paragraph before the one defining "anonymous boxes", like this:
What do you think? |
That's great, thanks! Well, as a mathematician I would use "Usually" instead of "In the general case" since being an ancestor is more general than being a parent, though I guess the expressions are synonyms in normal English :) Another nit: "such as" is repeated in the same sentence, maybe replace one of them with "like" or another synonym. |
The "general case" is the parent box being the principal box of the nearest ancestor element that generates a box. :) Switched to like and moved parenthetical. Current text:
|
Agenda+ to confirm, and request republication. List of changes at https://drafts.csswg.org/css-display-3/#changes ; specific changes can be seen at |
Disposition of Comments https://drafts.csswg.org/css-display-3/issues-cr-2018 |
The CSS Working Group just discussed
The full IRC log of that discussion<dael> Topic: Parent box of run-in or non-principal box<dael> github: https://github.com//issues/3158 <dael> fantasai: Trying to load this. I suspect this issue is just verifying something <dael> astearns: This is where you asked for repub so maybe this should be the last. <dael> fantasai: I think we brought this in F2F when requested pub. I think we reviewed <dael> astearns: And there are changes from a month ago. No changes to spec since F2F <dael> fantasai: I think when we resolved to pub it was including these and we forgot to remove agenda+ <dael> astearns: We did resolve to repub a month ago? <dael> fantasai: Yeah <dael> astearns: It's jsut not in this issue. <dael> astearns: That was display. <dael> fantasai: Yes, we don't have resolution for grid. Do for display <dael> astearns: Should we re-resolve to publish display? <dael> fantasai: I think resolution was in F2F but we can do it again <dael> astearns: Objections to republish Display? <dael> astearns: There's a DoC and a diff <chris> sounds good to me <dael> RESOLVED: Republish Display <chris> rrsagent, here <RRSAgent> See https://www.w3.org/2019/06/19-css-irc#T16-09-25 |
https://drafts.csswg.org/css-display-3/#css-parent-box says
Run-in boxes are described as an exception, but their "parent box" is not properly defined. Should be done in https://drafts.csswg.org/css-display-3/#run-in-layout. Intuitively it will be the "block box that does not establish a new block formatting context" to which the run-in sequence "is inserted as direct children".
And also the "parent box" of a non-principal box is not defined. In all element-generated cases it seems to be the principal box of the generating element. For anonymous boxes, maybe the nearest ancestor in the box tree which is a principal box.
The text was updated successfully, but these errors were encountered: