-
Notifications
You must be signed in to change notification settings - Fork 715
[resize-observer] Add layoutBox property to constructor #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have added |
@atotic can you review and provide feedback as well. |
A few comments: We should use an enum to define the value space of layoutBox, so that what happens when we pass in an invalid value is handled in a way consistent with other APIs. So something like:
and then use that instead of DOMString in all places. The result will be that an exception is thrown when invalid values are passed in. Then we should make the ResizeObserver constructor argument have a default value, so:
so then we don't need to do anything in the prose for the constructor to handle a missing/default value either. The header for the prose section describing the ResizeObserver constructor should be updated to have the layoutBox argument. The layoutBox declaration itself should be The prose description of |
@heycam @tabatkins thanks for the feedback. @atotic were both working in parallel on this and he has some solid ideas in a Google doc. After the breakout session we'll update the spec and get review again. |
Based on discussions and changes made by Alek I'm going to close this one out as we went in a slightly different direction. |
Currently, the default box returned to the author is the content-box but there are many scenarios in which the author wants the border box.
The text was updated successfully, but these errors were encountered: