Skip to content

[css-text-decor-3] ruby with dots examples seem incorrect #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
macnmm opened this issue Dec 12, 2018 · 4 comments
Closed

[css-text-decor-3] ruby with dots examples seem incorrect #3436

macnmm opened this issue Dec 12, 2018 · 4 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-text-decor-3 Current Work

Comments

@macnmm
Copy link

macnmm commented Dec 12, 2018

On several of the visual examples of dotted emphasis, the dot placement is too close to the base text.
https://www.w3.org/TR/css-text-decor-3/images/text-emphasis-ja.png
The emboxes of the base text and dotted emphasis glyphs should touch and not overlap. The size of the dotted glyphs' emboxes are normally 50% of those of the base text, although sometimes further scaling of glyphs is necessary for larger dots.

@fantasai
Copy link
Collaborator

OK, I made the images look pretty. Hopefully it's OK, the emphasis dot positions are still approximate. :)

@macnmm
Copy link
Author

macnmm commented May 24, 2019

If Murakami-san is fine I am fine.
Oops, that was for the other thing about placement with ruby.

The latest version of dot placement in https://drafts.csswg.org/css-text-decor-3/images/text-emphasis-ja.png looks great.

@fantasai fantasai added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label May 25, 2019
@fantasai
Copy link
Collaborator

fantasai commented May 25, 2019

Wait, was this a response to this issue or issue #3437 ?

@fantasai
Copy link
Collaborator

OK, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-text-decor-3 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants