-
Notifications
You must be signed in to change notification settings - Fork 715
[css-color-4] Allow percent as well as float 0.0 to 1.0 in color() args #3450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The spec already allows this for several types: namely |
While allowing, say, 50% as a synonym for 0.5 seems unproblematic, doing so would impact #278 were @tabatkins argues for adding percentage units to the L* value. So 50 and 50% would be synonymous, except now the spec would need to clarify that here, 50% means 50 not 0.5. Apart from that one issue, I don't see an issue with allowing percentage units as well as floats here. I don't want to hold up this issue for #278 so I'm going to agree with @faceless2 here and solve that other issue separately. |
Existing tests need to be updated to also check the percentage values. |
This change would also affect the |
With the recent resolution to 4649 adding |
Why, though? L* in |
Because all the other percentages resolve to 0.0 to 1.0, and because this issue is as well as |
So does L* in I see no WG resolution to make |
Percentages as well as floats were added in Allow percent as well as float 0.0 to 1.0 in color() args |
Tests now updated to take into account review feedback |
@faceless2 said
which is worthy of separate discussion.
The text was updated successfully, but these errors were encountered: