More WPT reviewers needed

[ewilligers]

Note a helpful tip that foolip circulated recently: Filter email by cc review_requested@noreply.github.com to see pull requests where you have been added as a reviewer.

It would be helpful if some people could volunteer as test reviewers for various CSS specs. Examples:

A trivial css-overflow test from September has no reviewer feedback.

A trivial css-rhythm test from October has no reviewer feedback.

A trivial compositing test from October has no reviewer feedback.

A trivial css-backgrounds test from October has no reviewer feedback. Other tests date back further.

A css-overscroll-behavior test from November has no feedback from the lone reviewer.

[rachelandrew]

I'd happily be a reviewer for any of the layout specs, overflow, or fragmentation. How do I get added as a reveiwer for particular specs?

[svgeesus]

Hi @ewilligers

Any idea what to do about things like

Travis CI - Pull Request Expected — Waiting for status to be reported which blocks reviewed tests from being merged?

[Ernedar]

Hello, are there any particular skills or special software needed to test those? I will volunteer for some testing. Thanks

…

On Wed, 9 Jan 2019 at 11:03, Chris Lilley ***@***.***> wrote: Hi @ewilligers <https://github.com/ewilligers> Any idea what to do about things like Travis CI - Pull Request Expected — Waiting for status to be reported <web-platform-tests/wpt#13575> which blocks reviewed tests from being merged? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI0jbk84yrAFt-xe7O5SyGDTatLhsYAVks5vBb6DgaJpZM4Z21eU> .

-- Jarda Fišer ---------------------------------------------------------------------------------- mob.: +420 776 205 205, e-mail: fiser.jarda@gmail.com

[ewilligers]

Any idea what to do about things like

Travis CI - Pull Request Expected — Waiting for status to be reported which blocks reviewed tests from being merged?

I was able to merge after rebasing. There was also the option of using the command line.

[ewilligers]

I'd happily be a reviewer for any of the layout specs, overflow, or fragmentation. How do I get added as a reveiwer for particular specs?

Each test directory has a META.yml

I uploaded web-platform-tests/wpt#14784 to add you to a number of review lists. Once you approve, an existing reviewer can merge it.

[fantasai]

@Ernedar If you haven't already, learn to write really good CSS tests. :) That's the only real qualification to be a good reviewer.

[ewilligers]

@Ernedar There are some tips on writing, reviewing and running tests at https://web-platform-tests.org/

The reviewer can be anyone (other than the original test author) that has the required experience with both the spec under test and with the general test guidelines.

[gsnedders]

FWIW: there's currently web-platform-tests/wpt#14798 (see web-platform-tests/wpt#13702 for discussion and pinging everyone who is removed) to remove people who seemingly never review anything. If you're not going to actively review anything and you're in any META.yml file, please remove yourself!

[css-meeting-bot]

The CSS Working Group just discussed More WPT reviewers needed.

The full IRC log of that discussion

<dael> Topic: More WPT reviewers needed
<dael> github: https://github.com//issues/3496
<dael> ericwilligers: I wanted to bring attention, there are a few specs with essentially no reviewers. Some people may be listed but don't check their review emails.
<rachelandrew> present +
<dael> ericwilligers: It would be helpful if more people volunteered. I can get Blink people to review, but that's not available to everyone. More people should be able to submit tests without going through a browser
<dael> Rossen_: In general we've had this discussion many times in the past. Both tests and test reviewers have been a struggle to come about.
<dael> Rossen_: Was there anything you were doing to gather external contributions
<dael> ericwilligers: No. This is tests I wrote that I thought it unfortunate no one is reviewing
<dael> gsnedders: It's notable that CSSWG specs are much harder to get review than any other spec. People who work on layout aren't interacting with wpt the way other groups are. Be interested to know reasons
<dael> chris: I've tried to review tests. I share ericwilligers frustration. I'l submit tests and they sit
<dael> dbaron: I review tests when I have time, but I think it may be more useful to bug individuals then bug the whole WG for reviews
<dael> ericwilligers: I spec a person and nothing happened
<dael> dbaron: Some of us have hundreds of thigns in github queues. If you want me to review something, send an email
<dael> ericwilligers: That's all for this issue, thanks
<tantek> Last time this topic came up, the larger problem of WPT being poorly documented (processes etc.) was the key takeaway
<tantek> pretty sure there was an issue filed too
<dael> Rossen_: Than you for bringing it to attention again. For us to be successful as a WG and making sure standards are pushed through, tests are a huge part. If anyone submits tests, please be accomodating. I'm bad at following all repo build up, but I try and respond to direct emails
<gsnedders> tantek: that doesn't explain the disparity between CSS and pretty much every other group, though
<dael> Rossen_: Let's see if we can drain that queue