Skip to content

[cssom][css-conditional] CSSGroupingRule interface is duplicated #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foolip opened this issue Jan 17, 2019 · 2 comments
Closed

[cssom][css-conditional] CSSGroupingRule interface is duplicated #3528

foolip opened this issue Jan 17, 2019 · 2 comments
Labels

Comments

@foolip
Copy link
Member

foolip commented Jan 17, 2019

The CSSGroupingRule interface is defined in two specs:
https://drafts.csswg.org/cssom/#the-cssgroupingrule-interface
https://drafts.csswg.org/css-conditional/#the-cssgroupingrule-interface

They are not identical, but the one in CSSOM looks like the one to keep.

@jugglinmike
Copy link
Contributor

Just stumbled over this myself.

As @foolip mentioned, there are a few discrepancies between the two. In particular, CSSOM defines an insertRule method whose second argument is optional, while CSS Conditional Rules' version of the method requires the second argument.

This seems to be a source of confusion since Chromium requires the argument, but Firefox and WebKit do not:

<style id="s"></style>
<script>
s.sheet.insertRule('@media all {}');
s.sheet.cssRules[0].insertRule('* {}'); // throws in Chromium only
</script>

For what it's worth, an optional argument is more consistent with the insertRule method of CSSStyleSheet.

jugglinmike added a commit to bocoup/csswg-drafts that referenced this issue Jun 11, 2019
CSSGroupingRule is defined by CSSOM.
jugglinmike added a commit to bocoup/wpt that referenced this issue Jun 11, 2019
These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528
jugglinmike added a commit to bocoup/wpt that referenced this issue Jun 12, 2019
These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528
zcorpan added a commit to zcorpan/csswg-drafts that referenced this issue Jun 26, 2019
dbaron pushed a commit that referenced this issue Jul 1, 2019
jugglinmike added a commit to bocoup/wpt that referenced this issue Jul 2, 2019
These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528
@jugglinmike
Copy link
Contributor

We resolved this issue via gh-4029 though I don't have the permissions to close it.

jugglinmike added a commit to web-platform-tests/wpt that referenced this issue Jul 2, 2019
These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528
@astearns astearns closed this as completed Jul 2, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 24, 2019
…nsertRule`, a=testonly

Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule

These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528

--

wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jul 25, 2019
…nsertRule`, a=testonly

Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule

These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528

--

wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276
natechapin pushed a commit to natechapin/wpt that referenced this issue Aug 23, 2019
These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
…nsertRule`, a=testonly

Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule

These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528

--

wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276

UltraBlame original commit: 6095a82d809c716895d2e1e2075cb59e3072bc42
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
…nsertRule`, a=testonly

Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule

These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528

--

wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276

UltraBlame original commit: 6095a82d809c716895d2e1e2075cb59e3072bc42
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
…nsertRule`, a=testonly

Automatic update from web-platform-tests
[cssom] Add tests for CSSGroupingRule

These tests are somewhat contentious due an inconsistency in the CSS
specification:

w3c/csswg-drafts#3528

--

wpt-commits: 814db842c492f8c480749b671e6bc31c83c68645
wpt-pr: 17276

UltraBlame original commit: 6095a82d809c716895d2e1e2075cb59e3072bc42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants