Skip to content

[css-flexbox] Definite sizes section could use clarification #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbiesinger opened this issue Jan 18, 2019 · 4 comments
Closed

[css-flexbox] Definite sizes section could use clarification #3531

cbiesinger opened this issue Jan 18, 2019 · 4 comments

Comments

@cbiesinger
Copy link

https://drafts.csswg.org/css-flexbox/#definite-sizes

Upon re-reading this section, I have a few suggestions for it:

  • Item 3 is only referring to flex items who are stretch-aligned, I believe. Also, instead of sayings "items ... are ... definite" it should say "cross-sizes of items" are definite.
  • Item 1 is not necessary, I believe. It follows automatically from item 3 / stretch handling combined with the fact that flex lines in single-line flex containers are sized to the container. So it seems this could be turned into a note / optimization opportunity (because you can avoid an extra layout pass in this case)

cc @fantasai

@fantasai fantasai added the css-flexbox-1 Current Work label Jan 21, 2019
fantasai added a commit that referenced this issue May 6, 2020
tabatkins added a commit that referenced this issue Jun 11, 2020
… a note), and genericize the third accordingly. #3531
@tabatkins
Copy link
Member

tabatkins commented Jun 11, 2020

It looks like fantasai's edit addresses your first bullet point.

I just pushed an edit handling your second; you're right, once we genericize the language in Item 3, it covers the Item 1 case entirely, so I just moved Item 1 to being a note.

@fantasai
Copy link
Collaborator

The second commit 6dd2edc is actually not editorial. We depend on the stretched size being definite when sizing the item in step 3, so we can't collapse these two points.

@fantasai
Copy link
Collaborator

fantasai commented Nov 4, 2020

[Two issues reported in this issue: one was accepted as editorial, the other rejected as invalid.]

@cbiesinger
Copy link
Author

sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants