Skip to content

[css-syntax] 4.3.11. Consume a name? #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tabatkins opened this issue Feb 1, 2019 · 0 comments
Closed

[css-syntax] 4.3.11. Consume a name? #3589

tabatkins opened this issue Feb 1, 2019 · 0 comments
Labels
Closed Rejected as Invalid Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-syntax-3 Testing Unnecessary Memory aid - issue doesn't require tests

Comments

@tabatkins
Copy link
Member

tabatkins commented Feb 1, 2019

(migrated from the mailing list)

Hiep, H.A. said:

The specification reads:

``Repeatedly consume the next input code point from the stream:''

And whenever the code point does not match the two clauses mentioned below,

``anything else
Return result.''

I believe that this description wrong. The current code point should be reconsumed, before returning the result, and preventing that a non-matching symbol from the input stream is eaten by the algorithm. A counter-example:

#ident{
}

would then first consume the "#", which triggers the Consume a name'-algorithm. It then continues with the name code point'-path, all the way up to "{". Here it returns result, while "{" is still consumed.

If I may suggest a better wording, it would be:

``anything else
Reconsume the current input code point and return result.''

See:
http://www.w3.org/TR/css-syntax-3/#reconsume-the-current-input-code-point
http://www.w3.org/TR/css-syntax-3/#consume-a-name


Tab Atkins said:

The /TR version is, as usual, out of date. This issue has been fixed
in the Editors Draft at
https://drafts.csswg.org/css-syntax/#consume-name for quite a while.
^_^


Hiep, H.A. said:

Thank you for your reply! In the future will I check the current draft before sending in my suggestions.

@tabatkins tabatkins added Closed Rejected as Invalid Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. Testing Unnecessary Memory aid - issue doesn't require tests css-syntax-3 labels Feb 1, 2019
@tabatkins tabatkins added this to the CSS Syntax 3 June 2019 CR milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Rejected as Invalid Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-syntax-3 Testing Unnecessary Memory aid - issue doesn't require tests
Projects
None yet
Development

No branches or pull requests

1 participant