Skip to content

[css-shapes] Minor typo in ellipse() syntax #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pyoor opened this issue Feb 4, 2019 · 0 comments · Fixed by #3618
Closed

[css-shapes] Minor typo in ellipse() syntax #3609

pyoor opened this issue Feb 4, 2019 · 0 comments · Fixed by #3618
Labels
css-shapes-1 Current Work

Comments

@pyoor
Copy link

pyoor commented Feb 4, 2019

The ellipse syntax is defined as ellipse( <shape-radius>{2}? [ at <position> ]? )

Based on the css-values definition, it looks like a brace multiplier followed by an optional element is illegal.

Shouldn't it be ellipse( [<shape-radius>{2}]? [ at <position> ]? )

csswg-drafts/css-shapes-1/Overview.bs

Line 379 in 6f9324a

ellipse( <<shape-radius>>{2}? [ at <<position>> ]? )

ewilligers pushed a commit to ewilligers/csswg-drafts that referenced this issue Feb 5, 2019
@ericwilligers
Address typo in ellipse() syntax
d995b65 
An ellipse may have an x-radius and y-radius, or neither.

resolves w3c#3609
@ewilligers ewilligers mentioned this issue Feb 5, 2019
Merged
ewilligers pushed a commit to ewilligers/csswg-drafts that referenced this issue Feb 5, 2019
@ericwilligers
Address typo in ellipse() syntax
38a3100 
An ellipse may have an x-radius and y-radius, or neither.

resolves w3c#3609
@dbaron dbaron added the css-shapes-1 Current Work label Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-shapes-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address typo in ellipse() syntax ewilligers/csswg-drafts
2 participants
@dbaron @pyoor