Skip to content

[css-grid] "Distribute space to base sizes up to growth limits" unclear #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Loirooriol opened this issue Feb 5, 2019 · 4 comments
Closed

Comments

@Loirooriol
Copy link
Contributor

From https://drafts.csswg.org/css-grid/#extra-space, "Distribute space to base sizes up to growth limits":

Find the item-incurred increase for each spanned track with an affected size

It's not clear whether "item-incurred increase" is a definition or a reference to some existing concept. I think the former, but it's not clear at first sight. I believe definitions should be in bold italic text, not just italic.

by distributing the space equally among them,

Does "them" refer to the spanned tracks or the affected size? I guess the latter. Also, it can seem this distribution is increasing the affected sizes, while in fact I understand that it goes to the item-incurred increase (and this is its definition).

freezing tracks as their size reaches their growth limit

It's not clear which size this is talking about. I guess it refers to the affected size plus the item-incurred increase.

Note: If the affected size was a growth limit, this step has no effect.

In that case I think the step is still defining "item-incurred increase", which is referenced by later steps. Isn't this an effect? The note could clarify that the "item-incurred increase" is then 0.

@fantasai
Copy link
Collaborator

fantasai commented Feb 7, 2019

It's not clear whether "item-incurred increase" is a definition or a reference to some existing concept. I think the former, but it's not clear at first sight. I believe definitions should be in bold italic text, not just italic.

It's a variable, and thus marked up with <var>.

Does "them" refer to the spanned tracks or the affected size? I guess the latter.

Right.

It's not clear which size this is talking about. I guess it refers to the affected size plus the item-incurred increase.

Right.

@fantasai
Copy link
Collaborator

fantasai commented Feb 7, 2019

Checked in some changes. Let me know if it's sufficient.

@Loirooriol
Copy link
Contributor Author

I guess it refers to the affected size plus the item-incurred increase.

Could you please clarify this in the spec?

@fantasai
Copy link
Collaborator

fantasai commented Feb 8, 2019

Done.

@fantasai fantasai closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants