8000 [cssom][css-transforms] Conflicting on resolved value of various properties · Issue #392 · w3c/csswg-drafts · GitHub
Skip to content

[cssom][css-transforms] Conflicting on resolved value of various properties #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
upsuper opened this issue Aug 9, 2016 · 7 comments · Fixed by #1019
Closed

[cssom][css-transforms] Conflicting on resolved value of various properties #392

upsuper opened this issue Aug 9, 2016 · 7 comments · Fixed by #1019
Assignees
@zcorpan
Labels
css-transforms-1 Current Work cssom-1 Current Work

Comments

@upsuper
Copy link
Member

upsuper commented Aug 9, 2016

CSSOM has a list of properties which should have their resolved value be their used value rather than computed value. That list doesn't include perspective-origin. However, CSS Transforms spec says the resolved value of perspective-origin should be used value.

I guess one of them should be changed to match the other.
@upsuper upsuper changed the title [cssom][css-transforms] Conflicting on resolved value of perspective-origin [cssom][css-transforms] Conflicting on resolved value of various properties Aug 9, 2016
@upsuper
Copy link
Member Author

upsuper commented Aug 9, 2016

This also applies to transform-origin.

@dbaron dbaron added css-transforms-1 Current Work cssom-1 Current Work labels Sep 28, 2016
@fantasai
Copy link
Collaborator

We should probably just update the CSSOM spec to say that its list is limited to CSS2 properties, and all other properties are as specified by their respective modules (defaulting to computed value).

@dbaron
Copy link
Member

dbaron commented Dec 29, 2016

It probably needs to be a slightly larger set than CSS2, representing "modules predating CSSOM". (Much like transforms does for the Animation type...)

zcorpan added a commit to zcorpan/csswg-drafts that referenced this issue Jan 11, 2017
@zcorpan
[cssom][css-transforms] Allow other specs to specify 'resolved value'
96813db 
Fixes w3c#392.
@zcorpan zcorpan mentioned this issue Jan 11, 2017
Merged
tabatkins pushed a commit that referenced this issue Jan 12, 2017
@zcorpan @tabatkins
[cssom][css-transforms] Allow other specs to specify 'resolved value' (…
8a65223 
…#882)

Fixes #392.
@fantasai fantasai reopened this Feb 9, 2017
@fantasai
Copy link
Collaborator

fantasai commented Feb 9, 2017

Reopening because I don't think this was correctly handled. In particular, the CSSOM specifies, for properties that have resolved value as used value, certain rules for e.g. handling display: none. The specs that reference the new term “resolved value special case property” do not contain these caveats.

I think “resolved value special case property” is overly-general. It seems to me that the properties that do not resolve to the computed value follow one of the existing patterns in the CSSOM, and therefore we should have these properties specifically reference those rules, not make up their own rules, which are intended to be the same as what's in CSSOM but aren't.

@zcorpan
Copy link
Member

zcorpan commented Feb 10, 2017 •
edited
Loading

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4880 shows transform-origin and perspective-origin should be like 'height'

zcorpan added a commit that referenced this issue Feb 10, 2017
@zcorpan
[cssom][css-grid][css-transforms] Make 'transform-origin' and 'perspe…
ce4c1ad 
…ctive-origin' resolved value like 'height'

Fixes #392.
@zcorpan zcorpan mentioned this issue Feb 10, 2017
Merged
@fantasai
Copy link
Collaborator

Are there any “resolved value special case properties” aside from top/left/bottom/right that do not resolve like 'height'?

@zcorpan
Copy link
Member

zcorpan commented Feb 20, 2017

Yes. The 'grid-template-rows' and 'grid-template-columns' properties.

zcorpan added a commit that referenced this issue Mar 9, 2017
@zcorpan
[cssom][css-grid][css-transforms] Make 'transform-origin' and 'perspe…
2317722 
…ctive-origin' resolved value like 'height'

Also mention that 'grid-template-rows' and 'grid-template-columns'
are resolved value special case properties (no normative change).

Fixes #392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcorpan zcorpan

Labels
css-transforms-1 Current Work cssom-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cssom][css-grid][css-transforms] Make 'transform-origin' and 'perspe… w3c/csswg-drafts
4 participants
@zcorpan @dbaron @upsuper @fantasai