Skip to content

[css-flexbox] min-height section should reference definite sizes instead of mentioning "does not prevent percentage resolution" #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbiesinger opened this issue Sep 16, 2019 · 3 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work

Comments

@cbiesinger
Copy link

https://drafts.csswg.org/css-flexbox/#min-size-auto

Nonetheless, although this may require an additional layout pass to re-resolve percentages in some cases, this value (like the min-content, max-content, and fit-content values defined in [CSS-SIZING-3]) does not prevent the resolution of percentage sizes within the item.

That should just say something like "This value does not prevent the block-size from being definite when it otherwise would be"

@fantasai @tabatkins

@tabatkins
Copy link
Member

I've rephrased the paragraph, check it over @cbiesinger?

(First paragraph already existed and is unaltered, just providing it for context since the new phrasing in the second paragraph references it more directly.)

For the purpose of calculating an intrinsic size of the box
(e.g. the box’s min-content size),
a content-based minimum size causes the box’s size in that axis to become indefinite
(even if e.g. its 'width' property specifies a definite size).
Note this means that percentages calculated against this size
will [=behave as auto=].

For other cases, it does not force the box's size to become indefinite.
However, if a percentage resolved against the box's size before this minimum was applied,
it must be re-resolved against the new size after it is applied.

@tabatkins
Copy link
Member

ping @cbiesinger (or @davidsgrogan?)

@davidsgrogan
Copy link
Member

LGTM

@tabatkins tabatkins added Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. and removed Commenter Response Pending labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-flexbox-1 Current Work
Projects
None yet
Development

No branches or pull requests

4 participants