-
Notifications
You must be signed in to change notification settings - Fork 717
[css-animations-2] List of pseudo-elements in composite order is non-exhaustive #4502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
At this point I tend to lean towards (4) (and work out the ordering for other pseudos once UAs actually need to animate them). I don't particularly like (1) since I believe the |
My personal leaning is towards 2. In the current spec, all pseudo-elements should be able to be targeted for animations (since we removed the requirement for EventTarget to make sense for the pseudo-element) and only animating before, after, and marker is a partial implementation. Restricting which pseudo-elements may be animated seems rather arbitrary. |
I guess the question is, is Blink looking to implement animation for other pseudos in the near future? If not, I don't think we should spec it yet. |
I'm hoping to do so as long as the code doesn't fight back too much. Our current implementation of hanging Animations off of blink::PseudoElement objects (likely the source of the restriction) has lifecycle issues and needs refactoring anyways, fixing it might make all pseudo-elements animatable. I don't think we should de-spec it just now. |
Fixup of w3c#4437 addressing w3c#4301. * Add pseudoElement option to KeyframeEffect constructor body * Fix w3c#4502 adding catch-all pseudo-element case to composite order * Fix w3c#4586 adding error handling to KeyframeEffect.pseudoElement * Fix w3c#4701 making note of case when property values cannot be calculated
…change. (#4616) Fixup of #4437 addressing #4301. * Add pseudoElement option to KeyframeEffect constructor body * Fixes #4502 by adding catch-all pseudo-element case to composite order * Fixes #4586 by adding error handling to KeyframeEffect.pseudoElement * Fixes #4701 by handling cases when property values cannot be calculated
In the definition of Animation composite order, the list of pseudo-elements only includes
::marker
,::before
, and::after
. Since many other pseudo-elements exist, and there is no section of the spec restricting animations to these particular pseudo-elements, How should we resolve this? I can think of a few possibilities.The text was updated successfully, but these errors were encountered: