Skip to content

[css-pseudo-4] Animations on ::marker? #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andruud opened this issue Feb 27, 2020 · 5 comments
Closed

[css-pseudo-4] Animations on ::marker? #4814

andruud opened this issue Feb 27, 2020 · 5 comments

Comments

@andruud
Copy link
Member

andruud commented Feb 27, 2020

We have some WPTs (mostly tentative) that expect animations and transitions to work on ::marker (see Chrome issue for list).

However, it appears that the spec does not currently allow animation and transition properties on ::marker. I'm wondering if there has been been any discussion regarding allowing this, or if we think it's a given that animations and transitions will be supported at some point.

Basically I'm wondering if I should remove ::marker from these tests, or keep them (if animation support is inevitable). (Sidenote: The reason this came up in the first place, is that the tests suddenly change behavior if ::marker is supported (via @supports selector)).

cc @birtles

@MatsPalmgren
Copy link

However, it appears that the spec does not currently allow animation and transition properties on ::marker.

What makes you think animation isn't allowed?

::marker is a CSSPseudoElement which makes it a target for animation (normative requirement). This was resolved in #3763 (comment).

@AmeliaBR
Copy link
Contributor

What makes you think animation isn't allowed?

There's an explicit allow-list of properties that currently apply to marker, until the full layout model can be specified.

My assumption would be that animation/transition of the allowed properties are also allowed & that the animation/transition properties apply — but I agree that this should be specified explicitly!

@AmeliaBR AmeliaBR added the css-pseudo-4 Current Work label Feb 27, 2020
@Loirooriol
Copy link
Contributor

Loirooriol commented Feb 28, 2020

Being able to animate the properties that apply to ::marker sounds reasonable. But note that ::first-letter and ::first-line also filter which properties apply to them, and you can't animate the allowed ones.

@fantasai
Copy link
Collaborator

fantasai commented Mar 4, 2020

I don't see a reason to disallow animations and transitions on ::marker, so adding them to the allow list makes sense.

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-pseudo-4] Animations on ::marker?, and agreed to the following:

  • RESOLVED: allow transitions on ::marker and allow animations with animations happening and animation rules applying the style
The full IRC log of that discussion <dael> Topic: [css-pseudo-4] Animations on ::marker?
<dael> github: https://github.com//issues/4814
<dael> fantasai: We have an allow list for properties on ::marker b/c haven't figured out layout. POinted out animations and transitions not allowed but makes sense they should work. Suggestion is add them to list
<dael> Rossen_: Other thoughts?
<dael> oriol: Seems reasonable but a note it may be inconsistent since first-letter and -line restrict properties and you can't animate them. It would be inconsistent but could make sense since marker is deviding.
<flackr> s/deviding/tree-abiding
<dael> oriol: May be a bit annoying for impl b/c it will bypass filters for which properties apply. SHouldn't be hard to do I guess
<fantasai> s/deviding/tree-abiding/
<dael> AmeliaBR: So that's practical impl issue if makes harder to tell which properties can be animated. Should be able to set transition property but only ones where it works are those where allowed. But logically if you can set color you should be able to animate color
<dael> dbaron: Note thing with filtering isn't an issue with transitions since they can only go between those that apply
<dael> AmeliaBR: Making sure keyframes are properly filtered out so only those that should have an effect do
<dael> Rossen_: Hearing some feedback this might be somewhat challenging to impl but from user expectation and behavior I don't hear reasons why it shouldn't be allowed
<dael> dbaron: I don't think that' challenging. BUt not w/ animations there's two technical ways to do it and they're distinguishable. You can say animation happens and an animation rule applying the style doesn't apply or you say animation doesn't happen. First I suspect is easier but second is better api
<dael> fantasai: Plan to add more properties to ::marker once we have a layout model. Probably want to go with way animation happens b/c then don't need infrastruction in style system. Hopefullya. temp situation
<dael> flackr: Also prefer first approach
<dael> dbaron: Do have to have infrastruction b/c that they don't apply has implications for computed value. Not sure
<dael> emilio: Have a filter but if impl in FF it's a one
<dael> Rossen_: Consensus seems to be allow transitions on ::marker and allow animations with them happening and animation rules applying the style
<dael> flackr: Animation is applyed, style not observed b/c doesn't take effect
<dael> Rossen_: Objections?
<dael> RESOLVED: allow transitions on ::marker and allow animations with animations happening and animation rules applying the style

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 25, 2020
As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 26, 2020
As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Mar 26, 2020
As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 26, 2020
As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 26, 2020
As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Mar 31, 2020
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 31, 2020
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Apr 1, 2020
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufauigalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442

UltraBlame original commit: 4f08bc06726bd4c97f630c5296b4d812324ff704
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Apr 1, 2020
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufauigalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442

UltraBlame original commit: 4f08bc06726bd4c97f630c5296b4d812324ff704
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Apr 1, 2020
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufauigalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruudchromium.org>
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Cr-Commit-Position: refs/heads/master{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442

UltraBlame original commit: 4f08bc06726bd4c97f630c5296b4d812324ff704
@fantasai fantasai closed this as completed Jul 8, 2020
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this issue May 1, 2025
…sitions in ::marker, a=testonly

Automatic update from web-platform-tests
[css-pseudo] Support animations and transitions in ::marker

As resolved in w3c/csswg-drafts#4814, allow
::marker to have animations or transitions. But only for the properties
that apply to ::marker.

TEST=external/wpt/css/css-animations/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-animations/animationevent-marker-pseudoelement.html
TEST=external/wpt/css/css-animations/event-order.tentative.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-transitions/Document-getAnimations.tentative.html
TEST=external/wpt/css/css-transitions/non-rendered-element-004.tentative.html

BUG=1054509

Change-Id: Ie86aeb42d4d311264fd5810c1ad89c0fa7b93ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119518
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753752}

--

wpt-commits: 906031fb2e88a47cf77b34ad1d7f3915da6343f9
wpt-pr: 22442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants