Skip to content

[css-grid-1] Grid baseline should only take baseline from spanning cells participating in the first/last row #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fantasai opened this issue Jul 6, 2020 · 0 comments
Closed

[css-grid-1] Grid baseline should only take baseline from spanning cells participating in the first/last row #5293

fantasai opened this issue Jul 6, 2020 · 0 comments
Labels
Closed Accepted as Obvious Bugfix css-grid-1

Comments

@fantasai
Copy link
Collaborator

fantasai commented Jul 6, 2020

Currently the spec says

If any of the grid items whose areas intersect the grid container’s first (last) row participate in baseline alignment, the grid container’s baseline set is generated from the shared alignment baseline of those grid items.

But actually this should be limited to the items participating in baseline alignment in that row, since a spanning cell could be participating in baseline alignment in a different row.

P.S. Also that should be “non-empty row”, to be consistent with #3645
fantasai added a commit to web-platform-tests/wpt that referenced this issue Jul 7, 2020
@fantasai
[css-grid] Check that 'align-self: last baseline' does not interfere …
aab1016 
…with baseline alignment in first row. w3c/csswg-drafts#5293
@fantasai fantasai mentioned this issue Jul 7, 2020
Merged
fantasai added a commit to web-platform-tests/wpt that referenced this issue Jul 7, 2020
@fantasai
[css-grid] Check that 'align-self: last baseline' does not interfere …
c3fdcba 
…with baseline alignment in first row. w3c/csswg-drafts#5293
fantasai added a commit to web-platform-tests/wpt that referenced this issue Jul 7, 2020
@fantasai
[css-grid] Check that 'align-self: last baseline' does not interfere …
e3698c7 
…with baseline alignment in first row. w3c/csswg-drafts#5293
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 10, 2020
@fantasai @moz-wptsync-bot
Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last …
7f82acf 
…baseline' does not interfere with baseline alignment in first row., a=testonly

Automatic update from web-platform-tests
[css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row. w3c/csswg-drafts#5293

--

wpt-commits: e3698c7bb3c309df69134e9bc0a375f00535e226
wpt-pr: 24477
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jul 10, 2020
@fantasai @moz-wptsync-bot
Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last …
4a356a3 
…baseline' does not interfere with baseline alignment in first row., a=testonly

Automatic update from web-platform-tests
[css-grid] Check that 'align-self: last baseline' does not interfere with baseline alignment in first row. w3c/csswg-drafts#5293

--

wpt-commits: e3698c7bb3c309df69134e9bc0a375f00535e226
wpt-pr: 24477
webkit-commit-queue pushed a commit to WebKit/WebKit that referenced this issue Apr 21, 2021
@ziransun @webkit-commit-queue
[css-grid] last-baseline shouldn't affect baseline alignment
d222a94 
https://bugs.webkit.org/show_bug.cgi?id=224538

Patch by Ziran Sun <zsun@igalia.com> on 2021-04-21
Reviewed by Darin Adler and Javier Fernandez.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-grid/alignment/grid-baseline-004-expected.txt:

Source/WebCore:

According to discussions at w3c/csswg-drafts#5293,
"align-self: last baseline" should not interfere with baseline alignment in
first row. This change is to make sure this is checked while deciding
whether an item participates in baseline alignment.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::isBaselineAlignmentForChild const):

Canonical link: https://commits.webkit.org/236834@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
yury-s pushed a commit to yury-s/webkit-http that referenced this issue Apr 21, 2021
[css-grid] last-baseline shouldn't affect baseline alignment
a62eeeb 
https://bugs.webkit.org/show_bug.cgi?id=224538

Patch by Ziran Sun <zsun@igalia.com> on 2021-04-21
Reviewed by Darin Adler and Javier Fernandez.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-grid/alignment/grid-baseline-004-expected.txt:

Source/WebCore:

According to discussions at w3c/csswg-drafts#5293,
"align-self: last baseline" should not interfere with baseline alignment in
first row. This change is to make sure this is checked while deciding
whether an item participates in baseline alignment.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::isBaselineAlignmentForChild const):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@276356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted as Obvious Bugfix css-grid-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fantasai