Skip to content

[css-grid-1] Spanning items increase doesn't handle min-content maximums #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fantasai opened this issue Jul 22, 2020 · 2 comments
Closed

[css-grid-1] Spanning items increase doesn't handle min-content maximums #5352

fantasai opened this issue Jul 22, 2020 · 2 comments
Labels
Closed as Duplicate css-grid-1

Comments

@fantasai
Copy link
Collaborator

In “Increase sizes to accommodate spanning items content-sized tracks”, we handle

  1. auto minimums
  2. min-content minimums
  3. max-content minimums
  4. auto maximums
  5. max-content maximums

It seems, however, that we don't handle the delta between an item’s auto and min-content contributions when min-content is specified as a maximum. :(
@Loirooriol
Copy link
Contributor

Dupe of #4790

@fantasai
Copy link
Collaborator Author

There's no such thing as an auto maximum, actually. This error was introduced when we dfn'ed “min-size contribution” f48098c and needs to be reverted.

fantasai added a commit that referenced this issue Jul 22, 2020
@fantasai
[css-grid-1] Revert accidental change from min-content to min-size in…
a8e1a6b 
… commit f48098c. #4790 #5352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed as Duplicate css-grid-1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fantasai @Loirooriol