Skip to content

[scroll-animations] Element based offsets should support rootMargin #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flackr opened this issue Oct 8, 2020 · 1 comment
Closed

[scroll-animations] Element based offsets should support rootMargin #5599

flackr opened this issue Oct 8, 2020 · 1 comment
Labels
scroll-animations-1 Current Work

Comments

@flackr
Copy link
Contributor

flackr commented Oct 8, 2020

In issue #4337 we proposed and added element based offsets but one thing that the pull request #5124 missed is adding the rootMargin for these element based offsets.

Specifically section 3.1.3.2 should have a rootMargin parameter which allows the developer to provide an offset from the scrolling box edge at which the intersection begins to take place similar to the same property in IntersectionObserver. It was mentioned in the issue and implemented in the polyfill but lost in the pull request. @majido I assume it was not intentionally dropped? I can't find any comments to suggest it was, and being able to offset from the edge can be quite useful.
@flackr flackr added the scroll-animations-1 Current Work label Oct 8, 2020
@flackr
Copy link
Contributor Author

flackr commented Aug 8, 2022

This is essentially the same request as #6068 and is resolved by #7243 where view-timeline-inset provides this functionality.

@flackr flackr closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scroll-animations-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flackr