Skip to content

[scroll-animations-1] Add Element-based offset (#4337) #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2020
Merged

[scroll-animations-1] Add Element-based offset (#4337) #5124

merged 3 commits into from
Jun 1, 2020

Conversation

majido
Copy link
Contributor

@majido majido commented May 27, 2020 •
edited
Loading

Add basic definition for Element-based offsets

Major changes:

  • Introduce concept of "scroll timeline offset" that can be container-based (existing concept) and element-based (new concept).
  • Add IDL for the new offset type and use it.
  • Define the process for each offset type to be resolved into an effective scroll offset.
  • Update current time calculation to resolve offsets and use the effective values.
  • Add basic diagram to show the behavior visually for a simple example

Minor changes:

  • Rewrap lines to fit in 80 chars
  • Trim end-of-line whitespace
  • Clarify some definitions

TODO (as follow ups):

  • Define threshold for element-based offset.
  • Add css syntax for element-based offsets.
  • Add more examples

@majido
Add Element-based offset (#)
eefd4a0 
Introduce concept of "scroll timeline offset" that can be
container-based (existing type) and element-based (new type)

Add IDL for the new offset type and use it.

Define the process for each offset type to be resolved into
an effective scroll offset.

Update current time calculation to resolve offsets and use
the effective values.

Minor changes:
 - reflow lines to fit in 80 chars
 - Clarify some definitions

TODO (as follow ups):
 - define threshold for element-based offset
 - Add a diagram to visualize the element-based computation
 - Add css syntax for element-based offsets
@majido majido requested a review from ogerchikov May 27, 2020 21:09
@majido majido added the scroll-animations-1 Current Work label May 27, 2020
@majido
Copy link
Contributor Author

majido commented May 27, 2020

@flackr FYI in case you have any comments.

@majido majido mentioned this pull request May 29, 2020
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jun 1, 2020
@majido @chromium-wpt-export-bot
[scroll-timeline] Correctly handle unresolvable cases
4be5f4c 
For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

There current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jun 1, 2020
Merged
@majido
Copy link
Contributor Author

majido commented Jun 1, 2020

Addressed nits in latest commit be7fcd7

@majido majido merged commit 5a49df2 into w3c:master Jun 1, 2020
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jun 1, 2020
@majido @chromium-wpt-export-bot
[scroll-timeline] Correctly handle unresolvable cases
74a6d1e 
For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jun 2, 2020
@majido @chromium-wpt-export-bot
[scroll-timeline] Correctly handle unresolvable cases
05a370e 
For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jun 2, 2020
@majido @chromium-wpt-export-bot
[scroll-timeline] Correctly handle unresolvable cases
52575c9 
For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}
pull bot pushed a commit to Yannic/chromium that referenced this pull request Jun 2, 2020
@majido
[scroll-timeline] Correctly handle unresolvable cases
7e84a0a 
For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.


[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 8, 2020
@majido @moz-wptsync-bot
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
a662447 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 8, 2020
@majido @moz-wptsync-bot
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
3016beb 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 9, 2020
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
d1682ad 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 9, 2020
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
49dc878 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 10, 2020
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
8120363 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 10, 2020
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
ab038c2 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jun 11, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
cc6abb2 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

UltraBlame original commit: 8d5970242b1ef3f361256b225805d097138569f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jun 11, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
ff7db6d 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 9d70834b865c54e1fbd354acd7a040d07899cfbb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jun 11, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
5ee11e6 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 7e3d78d04d1df89a7be533236cce0137b205cd6c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
af06b86 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

UltraBlame original commit: 8d5970242b1ef3f361256b225805d097138569f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
5e05a6f 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 9d70834b865c54e1fbd354acd7a040d07899cfbb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
ff8ea1a 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 7e3d78d04d1df89a7be533236cce0137b205cd6c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
5a027b5 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

UltraBlame original commit: 8d5970242b1ef3f361256b225805d097138569f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
023fc23 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 9d70834b865c54e1fbd354acd7a040d07899cfbb
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jun 12, 2020
@marco-c
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
30fdd82 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvpchromium.org>
Reviewed-by: Yi Gu <yiguchromium.org>
Commit-Queue: Majid Valipour <majidvpchromium.org>
Cr-Commit-Position: refs/heads/master{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787

UltraBlame original commit: 7e3d78d04d1df89a7be533236cce0137b205cd6c
birtles
birtles reviewed Jun 12, 2020
View reviewed changes
scroll-animations-1/Overview.bs
DOMString start = "auto";
DOMString end = "auto";
(DOMString or ElementBasedOffset) start = "auto";
(DOMString or ElementBasedOffset) end = "auto";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majido Should this patch have updated the types of the start and end members of the ScrollTimeline interface too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! And thanks for the patch to fix it.

@birtles birtles mentioned this pull request Jun 12, 2020
Merged
@flackr flackr mentioned this pull request Oct 8, 2020
Closed
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
@majido @moz-wptsync-bot
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
4342481 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
1a60415 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
@majido
Bug 1642327 [wpt PR 23889] - [scroll-timeline] Correctly handle unres…
9529071 
…olvable cases, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Correctly handle unresolvable cases

For these cases we cannot calculate a meaningful scroll offset:

1. When target is not a descendant of timeline's source.
2. When target has no layout box.

The current draft spec [1] asks for these situations to result into
unresolved scroll offset which keeps timeline inactive.

[1] w3c/csswg-drafts#5124

TEST: wpt/scroll-animations/element-based-offset-unresolved.html
BUG: 1023375

Change-Id: Iec616444dda8dcdd6649e250aa993b439c00885e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222884
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774144}

--

wpt-commits: 52575c9d7c3139cab33780e114b5cf9237a47157
wpt-pr: 23889

Differential Revision: https://phabricator.services.mozilla.com/D78787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birtles birtles birtles left review comments

@ogerchikov ogerchikov ogerchikov left review comments

Assignees
No one assigned
Labels
scroll-animations-1 Current Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majido @birtles @ogerchikov