[css-grid-1] Fix aspect-ratio errors in css-grid-1

[fantasai]

Commit 72f2bb2 which attempted to clarify the interaction of aspect-ratio with grid item sizing introduced some errors in the most recent CR. This has been fixed in 72f2bb2

The resulting text is https://drafts.csswg.org/css-grid-1/#grid-item-sizing

Agenda+ to verify the resulting text and republish as CRD. CC @cbiesinger @Loirooriol

[Loirooriol]

This has been fixed in 72f2bb2

I guess you mean ee91993. Looks good to me, but css-grid-2 will need to be fixed too.

[css-meeting-bot]

The CSS Working Group just discussed Fix aspect-ratio errors in css-grid-1, and agreed to the following:

• RESOLVED: accept aspect-ratio error changes in css-grid-1

The full IRC log of that discussion

<heycam> Topic: Fix aspect-ratio errors in css-grid-1
<heycam> github: https://github.com//issues/5615
<heycam> fantasai: there was a commit which attempted to clarify interaction of aspect-ratio and grid item sizing
<heycam> ... that introduced an error, which I fixed
<heycam> ... I'd like to verify the fix with the WG
<heycam> ... and republish grid-1 and grid-2 with the correction
<heycam> ... as a CRD
<heycam> Rossen_: is there a commit diff we should be looking at?
<heycam> ... or just that PR that you linked there
<fantasai> https://drafts.csswg.org/css-grid-1/#grid-item-sizing
<heycam> fantasai: commit I linked, that shows the fix to the problem, but the resulting text needs to be reviewed
<Rossen_> q?
<heycam> Rossen_: we resolved for this change that will be different from flexbox, right?
<heycam> fantasai: this one wasn't supposed to be a change, just a clarification
<heycam> ... can grab a diff against the older version
<fantasai> https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2F2017%2FCR-css-grid-1-20171214%2F&doc2=https%3A%2F%2Fdrafts.csswg.org%2Fcss-grid-1%2F#grid-item-sizing
<fantasai> https://github.com/w3c/csswg-drafts/commit/ee91993c92ba7d119a6b89c64667094511d67272
<chris> rrsagent, here
<RRSAgent> See https://www.w3.org/2020/10/19-css-irc#T20-30-55
<chris> rrsagent, make minutes
<RRSAgent> I have made the request to generate https://www.w3.org/2020/10/19-css-minutes.html chris
<heycam> Rossen_: any comments or objections to accept this diff?
<heycam> oriol: I think it's a good change, because there was a sentence saying that for stretch the rules would be modified to follow aspect-ratio. but impls were not doing that
<heycam> ... so if you have stretch, aspect-ratio is not taken into account
<heycam> ... so I think removing this sentence is good
<florian> I was hoping oriol had reviewed this. Given that he has, I feel confident it's fine :)
<dbaron> (There was a line attributed to me above that wasn't me, btw.)
<heycam> RESOLVED: accept aspect-ratio error changes in css-grid-1

[css-meeting-bot]

The CSS Working Group just discussed Fix aspect-ratio errors in css-grid-1, and agreed to the following:

• RESOLVED: publish a CRD for grid-1
• RESOLVED: publish a CRD for grid-2

The full IRC log of that discussion

<heycam> Topic: Fix aspect-ratio errors in css-grid-1
<heycam> github: https://github.com//issues/5615
<heycam> Rossen_: any objections to publishing a CRD for grid-1?
<heycam> RESOLVED: publish a CRD for grid-1
<heycam> Rossen_: and for grid-2?
<heycam> RESOLVED: publish a CRD for grid-2