-
Notifications
You must be signed in to change notification settings - Fork 709
[css-ui-4][css-images-4] Unify selector functions/values #5811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not blocking for this issue, but related to it: #5884 |
The Images instance shouldn't be merged with the others - it's defining an |
And yet it is the one that is using the most generic name with the And because it's combining two functionalities in one, I'd suggest to rather split them up. With that I mean allowing Sebastian |
Building further upon what @SebastianZ suggested: if This would come in very handy for scroll-linked animations, where you now have to duplicate timelines (see #5884) Above that, the whole idea for being more like
|
I'm with Bramus on this one; re-use the familiar and aim for parity with querySelector. Better for authors. |
FWIW scroll-animations-1 is no longer using the |
There are currently several specs defining different ways for referencing (ID) selectors:
<id>
element(<id-selector>)
selector(<id-selector>)
To improve the consistency between them, the syntax for referencing a selector should be merged.
Personally, I prefer the
selector()
function of Scroll Animations 1 because its name clearly outlines that it takes a selector and it is extensible as may allow other selectors then ID selectors in the future.See also the related discussion in #5166. And depending on the outcome of #1981, CSS Images 4 might be changed to not have a specific selector function anymore.
Sebastian
The text was updated successfully, but these errors were encountered: