Skip to content

[css-fonts] [palettes] base-palette and override-color should have their integer values be required to be nonnegative #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
litherum opened this issue Sep 16, 2021 · 2 comments · Fixed by #6650
Closed

[css-fonts] [palettes] base-palette and override-color should have their integer values be required to be nonnegative #6626

litherum opened this issue Sep 16, 2021 · 2 comments · Fixed by #6650
Assignees
@litherum
Labels
css-fonts-4 Current Work

Comments

@litherum
Copy link
Contributor

Currently, we have

base-palette: <integer> | <string>

That should probably be

base-palette: <integer [0, ∞]> | <string>

Also, we have

override-color: [ [ <string> | <integer> ] <color> ]#

That should probably be

override-color: [ [ <string> | <integer [0, ∞]> ] <color> ]#
@litherum litherum added the css-fonts-4 Current Work label Sep 16, 2021
@litherum litherum changed the title [css-fonts] base-palette and override-color should have their integer values be required to be nonnegative [css-fonts] [palettes] base-palette and override-color should have their integer values be required to be nonnegative Sep 17, 2021
@litherum
Copy link
Contributor Author

https://drafts.csswg.org/css-fonts/#om-fontpalettevalues says the key to maplike is unsigned.

@litherum litherum self-assigned this Sep 18, 2021
litherum added a commit to litherum/csswg-drafts that referenced this issue Sep 21, 2021
@litherum
[css-fonts] [palettes] base-palette and override-color should have th…
3c8279a 
…eir integer values be required to be nonnegative

Fixes w3c#6626.
@litherum litherum mentioned this issue Sep 21, 2021
Merged
@litherum
Copy link
Contributor Author

Pull request: #6650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@litherum litherum

Labels
css-fonts-4 Current Work
Projects
None yet
Milestone
No milestone
2 participants
@litherum @svgeesus