Skip to content

CSS Color 3: Proposed Changes #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svgeesus opened this issue Dec 23, 2021 · 9 comments
Closed

CSS Color 3: Proposed Changes #6910

svgeesus opened this issue Dec 23, 2021 · 9 comments
Assignees
Labels
Administrative Tracker For external review / publication tracking issues. css-color-3

Comments

@svgeesus
Copy link
Contributor

svgeesus commented Dec 23, 2021

The CSS Color 3 Recommendation of August 2021 has had enough time for review of the four Candidate Corrections so I would like to request transition to Recommendation with all four becoming Proposed Changes.

That makes them normative, triggers an AC review and patent exclusion opportunity, and after that they get folded into an updated Recommendation.

@svgeesus svgeesus added css-color-3 Administrative Tracker For external review / publication tracking issues. labels Dec 23, 2021
@svgeesus svgeesus self-assigned this Dec 23, 2021
@svgeesus
Copy link
Contributor Author

Although at least 3 of them could be considered editorial rather than substantive which has a simpler process so we should discuss that

@svgeesus
Copy link
Contributor Author

svgeesus commented Jan 9, 2022

Compare

so the discussion boils down to "are all of these changes editorial, or is any one of them substantive?

  1. Candidate Correction 1: Sample HSL values & conversion code. The samples are explicitly non-normative. The code does not claim to be normative, but does not explicitly say it is informative either.
  2. Candidate Correction 2: Clarified case-insensitive. Since all the existing color names are ASCII-only, the clarification that "case insensitive means ASCII case insensitive" has no substantive impact.
  3. Candidate Correction 3: Removed "Media" from property definition tables same as all recent specs. I don't think removing Media: visual has any substantive impact on the color property.
  4. Candidate Correction 4: Replaced "Call for implementation of dropped features" That section, which contained no normative statements but called for implementations of dropped features like @color-profile, has been replaced by an (explicitly non-normative) forward pointer to the higher-level specs where those features are now defined. So, editorial.

My proposal to the group is therefore that all four of these changes are editorial and so we can follow the "Updating a Rec with entirely editorial changes" route.

If the group finds one or more of these to be substantive, then we need to follow the more lengthy (Last Call for the AC, etc) route for the substantive one(s). The remaining editorial ones can be simply folded in at the same time.

@frivoal
Copy link
Collaborator

frivoal commented Jan 10, 2022

I agree that CC2, 3, and 4 are editorial.

For CC1, I am on the fence. Unless I read the spec to fast, there is no other definition (either inline or by reference) of HSL or of about how one is supposed to go from RBG to HSL or vice-versa, which makes it tempting to consider the conversion code normative. I guess that the intended interpretation is that the normative definition is of HSL is meant to be implied as HSL is a well-know scheme, and the sample code is meant to be informative… In practice, that's what really happened, and I don't think anyone was looking at the ABC code to try and figure out what HSL was, but based on the content of the document alone, this seems tricky to establish?

Does [COLORIMETRY], which is a normative reference, contain a definition of HSL which we could consider to be the normative one? That would provide an out.

@svgeesus
Copy link
Contributor Author

I guess that the intended interpretation is that the normative definition is of HSL is meant to be implied as HSL is a well-know scheme, and the sample code is meant to be informative

Yes, same as the other sample code.

Does [COLORIMETRY], which is a normative reference, contain a definition of HSL

No. But the original definition could be added:

Joblove, George H.; Greenberg, Donald (August 1978). "Color spaces for computer graphics" Computer Graphics. 12 (3): 20–25. doi:10.1145/965139.807362.

https://dl.acm.org/doi/10.1145/965139.807362 (paywall)
https://en.wikipedia.org/wiki/HSL_and_HSV#Joblove

@svgeesus
Copy link
Contributor Author

(Wikipedia btw currently has some stupid edit that HSL was invented in 1938, which is wildly incorrect.)

@svgeesus
Copy link
Contributor Author

I'm certainly going to add the original HSL paper as a normative reference to CSS Color 4. CSS Color 3 just mentioned it in passing as something well known. Should I add it there, too?

@svgeesus
Copy link
Contributor Author

svgeesus commented Jan 12, 2022

The CSS Working Group just discussed CSS Color 3: Proposed Changes, and agreed to the following:

  • RESOLVED: Republish CSS Color 3 REC as editorial update
The full IRC log of that discussion
[19:06]  Topic: CSS Color 3
[19:06]  chris: We published an updated REC that includes 4 candidate corrections
[19:06] == mode/#css [+o astearns] by Yves
[19:06]  chris: been up for review for a few months
[19:06]  chris: minor things like removing 'Media' lines in propdef tables
[19:06] == mode/#css [+o Rossen] by Yves
[19:06] == petercon [~petercon@79c2f29d.public.cloak] has joined #css
[19:06]  present+
[19:06]  chris: Main uncertainty is whether HSL is defined by pseudo-code or if the pseudo-code is informative
[19:07]  chris: my interpretation is the latter
[19:07]  chris: We did have a bug report that the JS in the examples was wrong, so fixed that
[19:07]  chris: and I added the JS from Color 4 to Color 3
[19:07] * Rossen_ ... now I know my ABCs, next time...
[19:07]  chris: My assertion is that everyone knows what HSL is, and defined by a paper (which is paywalled, but still)
[19:07]  chris: So my interpretation is the code is informative
[19:08]  chris: if we can agree as a group that all of those changes are not substantive, we can just republish the thing
[19:08]  chris: otherwise have to do full AC review
[19:08]  I vaguely remember having to regenerate a color table in the color spec at some point in the past...
[19:08]  fantasai: All the things I noticed when reviewing was editorial changes, so just republish
[19:08]  Publishing sounds fine to me too.
[19:08]  Rossen_: any other opinions?
[19:09]  RESOLVED: Republish CSS Color 3 REC as editorial update

@svgeesus
Copy link
Contributor Author

Publication requested Weds 12 Jan expected Tues 18 Jan

@svgeesus svgeesus removed the Agenda+ label Jan 12, 2022
@svgeesus
Copy link
Contributor Author

Published 18 Jan 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administrative Tracker For external review / publication tracking issues. css-color-3
Projects
None yet
Development

No branches or pull requests

3 participants