-
Notifications
You must be signed in to change notification settings - Fork 715
[css-fonts-4] font-palette:light and font-palette:dark are a bit disingenuous #7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmmmmmm, but Your suggested names are a mouthful, but considering shorter ones, I don't think mentioning "scheme" would help - calling a palette "light color scheme" would probably also imply (perhaps even more strongly!) that it involves light colors. Maybe just rewording the description to more directly reference the concept of light color schemes and referencing the MQ would help, and let us keep the short names? With an example showing off setting the palette to light or dark based on the MQ being light or dark? |
That's a good point! When authors say (prefers-color-scheme: light) they mean the background is light but the foreground is (probably) dark. I guess the difference is that, at least in my mind, "color scheme" implicitly includes both the foreground and background colors together as a package, but font color palettes only include the foreground.
Maybe just font-palette: light-background ??? 🤔 |
I have no strong opinion on this, but I tend to agree with Tab that short names can reasonably clearly be associated with the color schemes by the same name. Indeed, light means likely dark colors in the font, but if it's explained to be "goes with light scheme / light background", I think it's reasonably clear and not too verbose. +1 from my side to extending the explanation with an example and making reference to the |
I agree that similar names to the existing (light mode, dark mode) naming is clear and not likely to cause confusion. |
Okay let's close this then. |
The font can indicate certain palettes as
USABLE_WITH_LIGHT_BACKGROUND
orUSABLE_WITH_DARK_BACKGROUND
.CSS says:
However, a palette that is usable on a light background will probably involve dark colors. Therefore, when you say
font-palette: light
you are usually actually specifying a color palette whose colors are dark.Switching the meaning of
light
anddark
is probably not the right solution, though - the opentype flags say nothing about the foreground colors of the palettes. Maybe we should just copy the names from OpenType and renamelight
tousable-with-light-background
? Orusable-with-background(light)
?The text was updated successfully, but these errors were encountered: