Skip to content

[multiple] some specs store their images at top level, rather than in a /images folder #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbaron opened this issue Jul 15, 2022 · 9 comments

Comments

@dbaron
Copy link
Member

dbaron commented Jul 15, 2022

It appears that the images are all broken in the current TR draft of css-easing-1. I think it would be good to either (a) fix the images after the fact or (b) republish.

(I suspect this was the result of a mistake with echidna, given that it was published with echidna.)

@tabatkins
Copy link
Member

Specifically, the bikeshed echidna command automatically includes any files found in subfolders named images, diagrams, or examples, but doesn't include any files at the same level as the spec. (It's common for us to stash all sorts of things at the same level that shouldn't be part of the publication.)

@tabatkins
Copy link
Member

(I should probably do a check for local img urls that look like they're not in the blessed directories or a manually-specified directory.)

@dbaron
Copy link
Member Author

dbaron commented Jul 15, 2022

It looks like the following bikeshed-generated specs have images at toplevel:

  • css-animations-1
  • css-block-3 (sort of; there's no spec at all, just images)
  • css-easing-1
  • css-egg-1 (never published to TR)
  • css-line-grid-1
  • css-module (!!!)
  • css-speech-1
  • css-transitions-1

And the following use an img subdirectory:

  • scroll-animations-1
  • web-animations-1
  • web-animations-2

(I ignored specs generated using the old preprocessor.)

Edit: also the following houdini specs:

  • css-animation-worklet-1
  • css-layout-api

@dbaron
Copy link
Member Author

dbaron commented Jul 15, 2022

(I'm happy to make a PR to fix these, unless you're already doing it.)

@tabatkins
Copy link
Member

Not doing it, feel free to just push to main. ^_^

dbaron added a commit that referenced this issue Jul 15, 2022
@dbaron
Copy link
Member Author

dbaron commented Jul 15, 2022

Done. Now we just have the issue that perhaps css-easing-1 (and maybe other specs) should be republished.

dbaron added a commit to w3c/css-houdini-drafts that referenced this issue Jul 15, 2022
…ill automatically package.

(Also move a few *out* of such directories, in the case of css-layout-api.)

Fixes more of w3c/csswg-drafts#7505.
@fantasai
Copy link
Collaborator

Turned dbaron's comment into a checklist, and republished css-easing-1. css-egg-1 should be scheduled for April 1st, but hopefully we can get the rest updated soon. :)

@tabatkins tabatkins changed the title [css-easing-1] images broken in current TR draft [multiple] some specs store their images at top level, rather than in a /images folder Jul 30, 2024
@svgeesus
Copy link
Contributor

Why is this still open, it looks like the commit from @dbaron fixed all affected specs

@svgeesus
Copy link
Contributor

I checked (and then marked as complete in the checklist above) all the specs that were not checked. There were no required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants