-
Notifications
You must be signed in to change notification settings - Fork 715
[css-conditional-5] Queries re font-technology support queries #7633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @drott |
I'm sure I remember this being discussed in an issue, and we decided to try for just keywords, but I looked and can't find it. Does this ring bells for anyone else? |
The only related issue I can find seems to conclude we should accept both strings and keywords: |
I'd rather reduce the use of strings and agree with you that keywords are preferable here. The relevant issue that @svgeesus uncovered, #6328 has more of the discussion. IMO strings are accepted there for backwards compatibility and the only strings allowed in CSS
No strong opinion, but I think the idea for the
+1 to changing to the plural form. Looking at this edit 548dab8 when we moved from |
Re (2), I agree that for
which makes it sound as though whatever you can say in I don't feel strongly one way or the other about this, but I guess I do lean towards consistency between the |
…nabled only on Nightly for now. r=emilio There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…nabled only on Nightly for now. r=emilio, a=RyanVM There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
@jfkthame Could you split out (3) into a separate issue and perhaps we can resolve that quickly? That, I think, would enable shipping the feature while we continue discussing additional argument types (strings) or multiple arguments. |
|
I think consistency here was the original design intent. |
If we do decide to retain keywords-only for Conditional, I suggest adding a note in Fonts like: Note: for backwards compatibility, this descriptor also accepts a string, which must be one of the following: "woff", "truetype", "opentype", "woff2", "embedded-opentype", "woff2-variations". The CSS WG does not expect to increase the set of accepted strings. |
That sounds good, with one adjustment: it wouldn't ever have made sense to recognize only "woff2-variations" but not "-variations" variants of the other formats, and indeed Firefox (at least) does also recognize "truetype-variations", "opentype-variations", and "woff-variations". The existing WPT test at css/css-fonts/format-specifiers-variations.html also expects these strings to be accepted. |
Agree, looking at the source I found that we accept: |
OK great, I will add that exact list to the spec, then. |
I'm writing:
and want to add
Treated as if no format had been specified? |
In my prototype implementation, I am rejecting those entries of the src: line and not adding them to the list of supported resources. Reasoning being: If it's a format that the UA hasn't heard of, there's not much point in trying this resource. And that behaviour is what I would suggest specifying. Curious to hear @jfkthame's point of view. |
I notice we have this left-over section format strings which is originally from CSS Fonts 3. It is older, in that it describes the obsolete SVG font format and doesn't have the short-lived Looks like I should merge these two, moving the recently added table here, and then adding a column with the links to format specifications. |
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
…only on Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In w3c/IFT#113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In w3c/csswg-drafts#7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
re-tagging as css-fonts-4 because css-conditional-5 now simply references css-fonts-4 for the |
The Conditional Rules level 5 spec extends
@supports
with newfont-tech()
andfont-format()
functions. In looking to implement these, a few minor questions have come up that I'd like to clarify/confirm.(1) The syntax for
font-format()
appears to accept only keywords, whereas theformat()
function in the CSS Fonts @font-face src descriptor accepts either a keyword or a string. While I think keywords are preferable here, I wonder whether we should also accept the string syntax in@supports font-format(...)
for consistency with the@font-face
descriptor?(2) The syntax for
font-tech()
accepts a single keyword identifying a font technology. In contrast, thetech()
function in CSS Fonts accepts a comma-separated list of font technology keywords. Should@supports font-tech(...)
similarly accept a list?(3) A really minor issue, but I have found myself repeatedly writing things like
@supports font-tech(features-opentype)
, and not getting the expected result because the correct keyword isfeature-opentype
(singular). To my mind, thefeature-*
keywords would read more naturally in the plural form (similarly tofont-tech(variations)
). Should we change them to plural, here and in CSS Fonts, before this is widely implemented and webcompat becomes a constraint?The text was updated successfully, but these errors were encountered: