-
Notifications
You must be signed in to change notification settings - Fork 708
[css-color] Previews in <pre> blocks—rendering bug #7688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This has been fixed in the editor's draft, see for example https://drafts.csswg.org/css-color-5/#ex-swop5v2 As a consequence of this fix, the "link to this example" self-link is also visible. This change will propagate to the /TR version next time it is published. |
@matatk could you confirm that you no longer see this issue, in the Editor's Draft? |
@svgeesus actually I am still finding this issue, e.g. in Example 13 and others in the Editor's Draft. It seems to be a problem when the code example is just one line high. The visible self-links are very handy, though looks like the current implementation poses at least one accessibility barrier (lack of clear name), and might have a contrast issue. I have made a note to come back and check this out and file issues and suggestions if needed. (Thanks for your quick replies on all of these APA issues; I'll respond as soon as I'm able.) |
OK, I found and fixed it. |
If so, please file them on Bikeshed so they get fixed for all specifications, not just this one. |
I believe it is fine. Text color is |
Just to confirm: Example 13 and others in the Editor's Draft are now working for me too; thanks. I had a quick look at several others, and they were all fine. Your fix to the CSS seems comprehensive, so feel free to close this if you too think it's all addressed. |
This comment is from the APA WG and relates to our review of CSS Color Module Level 5.
The previews inside code example blocks can't expand outside of those blocks, so aren't drawn fully in those cases. Would it be possible to alter the rendering, so that the blocks can expand visually to their usual full size, even when they're in
<pre>
blocks?The text was updated successfully, but these errors were encountered: