Skip to content

[css-color] Previews in <pre> blocks—rendering bug #7688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matatk opened this issue Sep 4, 2022 · 7 comments
Closed

[css-color] Previews in <pre> blocks—rendering bug #7688

matatk opened this issue Sep 4, 2022 · 7 comments
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification

Comments

@matatk
Copy link

matatk commented Sep 4, 2022

This comment is from the APA WG and relates to our review of CSS Color Module Level 5.

The previews inside code example blocks can't expand outside of those blocks, so aren't drawn fully in those cases. Would it be possible to alter the rendering, so that the blocks can expand visually to their usual full size, even when they're in <pre> blocks?

@svgeesus
Copy link
Contributor

svgeesus commented Sep 4, 2022

This has been fixed in the editor's draft, see for example

https://drafts.csswg.org/css-color-5/#ex-swop5v2

As a consequence of this fix, the "link to this example" self-link is also visible.

This change will propagate to the /TR version next time it is published.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 5, 2022

@matatk could you confirm that you no longer see this issue, in the Editor's Draft?

@svgeesus svgeesus added the css-color-5 Color modification label Sep 5, 2022
@matatk
Copy link
Author

matatk commented Sep 5, 2022

@svgeesus actually I am still finding this issue, e.g. in Example 13 and others in the Editor's Draft. It seems to be a problem when the code example is just one line high.

The visible self-links are very handy, though looks like the current implementation poses at least one accessibility barrier (lack of clear name), and might have a contrast issue. I have made a note to come back and check this out and file issues and suggestions if needed.

(Thanks for your quick replies on all of these APA issues; I'll respond as soon as I'm able.)

@svgeesus
Copy link
Contributor

svgeesus commented Sep 5, 2022

It seems to be a problem when the code example is just one line high.

OK, I found and fixed it.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 5, 2022

have made a note to come back and check this out and file issues and suggestions if needed.

If so, please file them on Bikeshed so they get fixed for all specifications, not just this one.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 5, 2022

might have a contrast issue.

I believe it is fine. Text color is rgb(3,69,117) and background is white, so APCA Lc is 92.5

@svgeesus svgeesus mentioned this issue Sep 5, 2022
5 tasks
@matatk
Copy link
Author

matatk commented Sep 6, 2022

OK, I found and fixed it.

Just to confirm: Example 13 and others in the Editor's Draft are now working for me too; thanks. I had a quick look at several others, and they were all fine. Your fix to the CSS seems comprehensive, so feel free to close this if you too think it's all addressed.

@svgeesus svgeesus closed this as completed Sep 6, 2022
@svgeesus svgeesus added Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Obvious Bugfix Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-color-5 Color modification
Projects
None yet
Development

No branches or pull requests

2 participants