Skip to content

[css-grid] editorial: typos in Subgrids section #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alligatorio opened this issue Dec 24, 2016 · 1 comment
Closed

[css-grid] editorial: typos in Subgrids section #835

alligatorio opened this issue Dec 24, 2016 · 1 comment

Comments

@alligatorio
Copy link

https://www.w3.org/TR/css-grid-1/#subgrids

Under Example 27, I think that there are 3 minor typos. The first 2 in the following paragraph:

If the subgrid has margins/borders/padding, the the size of those margins/borders/padding also influence sizing.

Note the duplicate the, and I also believe that influence should be influences, given the singular size subject.

Also, the last one in the last paragraph:

#subgrid { padding: 100px; }

Then a grid item in the subgrid’s first track acts as if it has an additional 100px of top, left, and bottom margin influencing the sizing of the parent grid’s tracks and the grid item’s own position.

I believe that padding should be referenced in that paragraph instead of margin.

@fantasai
Copy link
Collaborator

fantasai commented Feb 1, 2017

Fixed the first one. The second one (padding vs. border) was intentional: the extra space is added outside the visible bounds of the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants