Skip to content

[css-scrollbar] scrollbar-width animation type wrong? #8873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukewarlow opened this issue May 24, 2023 · 4 comments
Closed

[css-scrollbar] scrollbar-width animation type wrong? #8873

lukewarlow opened this issue May 24, 2023 · 4 comments
Labels
Closed Accepted by Editor Discretion css-scrollbars-1 Current Work Tested Memory aid - issue has WPT tests

Comments

@lukewarlow
Copy link
Member

According to the current specification the animation type of scrollbar-width is "by computed value" but this property only supports 3 keywords so I would expect it to be "discrete"?

@frivoal frivoal added the css-scrollbars-1 Current Work label May 26, 2023
@frivoal
Copy link
Collaborator

frivoal commented May 26, 2023

You're right, this is a leftover from when scrollbar-width took <length> values. It no longer does, so switching to discrete does make sense.

@frivoal
Copy link
Collaborator

frivoal commented May 26, 2023

Fixed in d72cc57

@frivoal frivoal closed this as completed May 26, 2023
@lukewarlow
Copy link
Member Author

What test case would be required for this? I'd be happy to file a PR to the WPT repo for them.

https://github.com/web-platform-tests/wpt/pull/40124/files I've already added it as discrete to the animation property list (change from where I implemented parsing for it in WebKit)

If there's any other tests that need changing let me know

@frivoal
Copy link
Collaborator

frivoal commented May 26, 2023

I hadn't seen that test, thank you for the cross reference. That seems to cover it at least at the basic level. Some ref-test would be nice to have too, to confirm that it's doing the right thing not just at the API level, but also visually, but with scrollbars, that can be a little hard to construct.

@frivoal frivoal added Tested Memory aid - issue has WPT tests and removed Needs Testcase (WPT) labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by Editor Discretion css-scrollbars-1 Current Work Tested Memory aid - issue has WPT tests
Projects
None yet
Development

No branches or pull requests

2 participants