Skip to content

[css-writing-modes] Application of text-combine-upright should be defined in terms of typographic mode #9176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nt1m opened this issue Aug 10, 2023 · 2 comments
Open

[css-writing-modes] Application of text-combine-upright should be defined in terms of typographic mode #9176

nt1m opened this issue Aug 10, 2023 · 2 comments
Assignees
@frivoal @fantasai
Labels
css-writing-modes-3 css-writing-modes-4 Current Work Needs Edits Tested Memory aid - issue has WPT tests

Comments

@nt1m
Copy link
Member

nt1m commented Aug 10, 2023

Gecko seems to check the direct writing mode values: https://searchfox.org/mozilla-central/rev/778df10b835ea87def2bfdbb83810ee36bc22c94/servo/components/style/style_adjuster.rs#338-341

but it seems like checking the typographic mode would make sense.

This is not really specified in the spec.
@fantasai
Copy link
Collaborator

Gecko is checking the typographic mode by looking up the writing-mode value. (That test doesn't trigger on the sideways-* values.) Which seems correct: the point of the sideways-* values was to use horizontal typesetting conventions, graphically rotated sideways.

Agreed the spec should clarify this, and we should have a test for it.

@nt1m
Copy link
Member Author

nt1m commented Aug 14, 2023

Testcases already exist, I think this is mostly an editorial change.

css/css-writing-modes/text-combine-upright-sideways-001.html
css/css-writing-modes/text-combine-upright-sideways-002.html

@frivoal frivoal added the Tested Memory aid - issue has WPT tests label Feb 20, 2024
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 2, 2024
@tkent-google
sideways: text-combine-upright should not work
3baa420 
w3c/csswg-drafts#9176

Bug: 40501131
Change-Id: I0008009596e396c2159eeffe0259b6989cb79745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5671539
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321989}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frivoal frivoal

@fantasai fantasai

Labels
css-writing-modes-3 css-writing-modes-4 Current Work Needs Edits Tested Memory aid - issue has WPT tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frivoal @fantasai @nt1m