-
Notifications
You must be signed in to change notification settings - Fork 710
[css-pseudo][css-writing-modes] text-orientation
and ::marker
#9788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe that should change, but with the current specs, browsers seem compliant here. |
Fair point. I guess text-orientation has two (families of) effects:
It seems logical for the second one to be anchored on actual elements. The first one would make more sense to me to apply to text, so a possible fix for this issue would be to change the Applies To line from "all elements except[…]" to "text, and all elements except […]". From a compat point of view, that ought to be largely OK:
If we don't want to do that, I would argue that would ought to include it in the properties explicitly allowed on |
This is upright on Gecko, Blink and WebKit: <div style="writing-mode: vertical-rl">
<div style="display: contents; text-orientation: upright">AB</div>
</div> So I guess it's implemented as applying to text indeed. |
In fact since inline elements/boxes are not excluded, and it's inherited, then it needs to apply to text as per #5303 (comment). |
So, it would seem that this needs no normative spec correction. We'll need at least some tests, but should we add an informative statement? Maybe include one more bullet point in example 4 highlighting the conclusion reached in #5303 (comment) that “inheritable properties that apply to inlines also apply to text”. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Edits made. @Loirooriol Please confirm that the issue is resolved, and close the issue if so. :) Thanks~ |
Spec-wise, looks good to me. Tests added by web-platform-tests/wpt#51571 |
…stonly Automatic update from web-platform-tests Add tests for w3c/csswg-drafts#9788 (#51571) -- wpt-commits: 11a29e30719bbf49b79441d68885072e62a5e165 wpt-pr: 51571
…stonly Automatic update from web-platform-tests Add tests for w3c/csswg-drafts#9788 (#51571) -- wpt-commits: 11a29e30719bbf49b79441d68885072e62a5e165 wpt-pr: 51571
…stonly Automatic update from web-platform-tests Add tests for w3c/csswg-drafts#9788 (#51571) -- wpt-commits: 11a29e30719bbf49b79441d68885072e62a5e165 wpt-pr: 51571
…stonly Automatic update from web-platform-tests Add tests for w3c/csswg-drafts#9788 (#51571) -- wpt-commits: 11a29e30719bbf49b79441d68885072e62a5e165 wpt-pr: 51571
See discussion in w3c/csswg-drafts#9788 Also doing the same for the -webkit-text-orientation surrogate. Fixed: 406109039 Change-Id: I1f27da0ec9b14e2fd978034f901a85455ac533a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432726 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#1443147}
text-orientation
should have an effect on::marker
, so that, for instance, you can have upright numerals in a numbered list's markers, and otherwise mixed orientation text.Here's a test case: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=12266
Currently, all browsers fail it. I think that's a browser bug, as even though
text-orientation
isn't part of the set of properties that apply directly to the::marker
pseudo, it should inherit into the text inside the marker and apply there. Do we agree, or is there something somewhere in the spec that actually makes it the expected behavior?The text was updated successfully, but these errors were encountered: