-
Notifications
You must be signed in to change notification settings - Fork 716
[css-view-transitions-2] CSSViewTransitionRule.type
overrides deprecated CSSRule.type
#9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
No, this does need fixing. The naming clash is unfortunate, but subclasses shouldn't override an attribute with an incompatible type. |
OK, proposing |
The CSS Working Group just discussed
The full IRC log of that discussion<Frances> Tab: CSSViewTransitionRule as a .type is deprecated, it needs renaming such as typeList instead.<bramus> SGTM <TabAtkins> .type is already used in CSSRule (it's deprecated) <Frances> PROPOSAL: Change CSSViewTransitionRule .type to .typeList <Frances> RESOLVED: Change CSSViewTransitionRule .type to .typeList |
Probably too late but it would have been nice to match the descriptor, the CSS rule attribute, and the argument property for It allows blindly defining descriptors from the specified declarations with the appropriate algorithm, as is usually (always?) the case with other CSS rules mirroring specified declarations and exposed attributes. |
One may expect
0
from gettingCSSViewTransitionRule.type
.I guess it is ok if it returns the descriptor value, but I would just like to make sure.
The text was updated successfully, but these errors were encountered: