[css-view-transitions-2] Update the algorithm to check opt-in on outbound transition #10078
Conversation
|
This is required for whatwg/html#10178 |
…ound transition Instead of relying on the source snapshot params in HTML, we update a flag every time something relevant changes, and HTML can read that flag.
| @@ -450,6 +450,11 @@ Note: as per default behavior, the ''@view-transition'' rule can be nested insid | |||
| Note: the [=@view-transition/type=] descriptor only applies to the {{Document}} in which it is defined. | |||
| The author is responsible for using their chosen set of types in both documents. | |||
|
|
|||
| ## Responding to changes in the ''@view-transition'' rule ## {#respond-to-rule-changes} | |||
|
|
|||
| When the ''@view-transition'' rule changes for {{Document}} |document|, [=update the opt-in state for outbound transitions=] given |document|. | |||
There was a problem hiding this comment.
Should we leave a note here to the effect of, "The UA is responsible for deciding when style resolution is executed to keep the opt-in state in sync with style mutations".
There was a problem hiding this comment.
I don't think that's necessary.
| @@ -736,6 +747,10 @@ Prepend this to the [=Perform pending transition operations=] algorithm given a | |||
|
|
|||
| 1. [=Assert=]: |document| is [=fully active=]. | |||
|
|
|||
| 1. [=Assert=]: |document| [=has been revealed=] is true. | |||
There was a problem hiding this comment.
Do we still need to export this algorithm? It looks like for the new Document we're calling it within this spec in "resolve cross-document view-transition" and html should now use the can initiate outbound view transition bit.
There was a problem hiding this comment.
Export which algorithm?
There was a problem hiding this comment.
"resolve cross-document view-transition" shouldn't need to be visible outside this spec now. Can fix after the html rewrite lands.
There was a problem hiding this comment.
It's still called from page reveal, that's not changed here
There was a problem hiding this comment.
What we don't need is "Resolve @view-transition rule", it's already not exported.
There was a problem hiding this comment.
I renamed it, I think it's clearer now
| @@ -736,6 +747,10 @@ Prepend this to the [=Perform pending transition operations=] algorithm given a | |||
|
|
|||
| 1. [=Assert=]: |document| is [=fully active=]. | |||
|
|
|||
| 1. [=Assert=]: |document| [=has been revealed=] is true. | |||
There was a problem hiding this comment.
"resolve cross-document view-transition" shouldn't need to be visible outside this spec now. Can fix after the html rewrite lands.
This refactors the cross-document deactivation part of the navigation algorithm to use fewer closures and instead a couple of top-level algorithms. It also fixes an issue where the incorrect document was being checked for the view transitions opt-in. This integrates with the new View Transitions hook being introduced in w3c/csswg-drafts#10078.
This refactors the cross-document deactivation part of the navigation algorithm to use fewer closures and instead a couple of top-level algorithms. It also fixes an issue where the incorrect document was being checked for the view transitions opt-in. This integrates with the new View Transitions hook being introduced in w3c/csswg-drafts#10078.
This refactors the cross-document deactivation part of the navigation algorithm to use fewer closures and instead a couple of top-level algorithms. It also fixes an issue where the incorrect document was being checked for the view transitions opt-in. This integrates with the new View Transitions hook being introduced in w3c/csswg-drafts#10078.
Instead of relying on the source snapshot params in HTML, we update a flag every time something relevant changes, and HTML can read that flag.
[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.
Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.