[css-view-transitions-2] Refactor based on topics #10098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css-view-transitions-2/Overview.bs
Outdated
| ### The <dfn id="at-view-transition-rule">''@view-transition''</dfn> rule ### {#view-transition-rule} | ||
|
|
||
| The ''@view-transition'' rule is used by a document to indicate that cross-document navigations | ||
| should setup and activate a {{ViewTransition}}. To take effect, it must be present in the old document |
There was a problem hiding this comment.
Can we move "To take effect, it must be present in the old document ... is fired" to a non-normative note?
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
css-view-transitions-2/Overview.bs
Outdated
| In this way, the author can use the the <code data-x="">blocking</code> attribute, to delay the transition until: | ||
| * All expected scripts are executed, by using the script's {{HTMLScriptElement/blocking}} attribute on required scripts. | ||
| * All expected styles are executed, by using the style or link's {{HTMLStyleElement/blocking}} attribute on required styles. | ||
| * All expected HTML elements are seen by the parser, using an [^link/rel/expect^] {{HTMLLinkElement}} element. |
There was a problem hiding this comment.
"[^link/rel/expect^]" isn't linked properly.
css-view-transitions-2/Overview.bs
Outdated
|
|
||
| : <dfn><<custom-ident>>+</dfn> | ||
| :: All of the specified <<custom-ident>> values (apart from <css>none</css>) are applied when used in [=named view transition pseudo-element=] selectors. | ||
| <css>none</css> is an invalid <<custom-ident>> for 'view-transition-class', even when combined with other <<custom-ident>>s. |
There was a problem hiding this comment.
I'm not sure why but "<>" in this line is not getting linked...
|
One more thing, can you use https://api.csswg.org/bikeshed/ after making edits to confirm there's no errors/typos. |
khushalsagar
approved these changes
Mar 22, 2024
vmpstr
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10011
Closes #10070
Closes #10071