[mediaqueries] Lift <media-feature> parens to <media-in-parens> (#6806) #10131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies 1af56e0 to MediaQueries 5. This commit was made 3 years ago, after initiating from MediaQueries 4.
Also, the railroad diagram of the updated syntax was not updated accordingly. This PR updates it in both levels of the spec.
Without this change, a container size query will match
<general-enclosed>and evaluate tounknown, unless it is specified in two()-blocks, because<query-in-parens>(CSS Contain) produces( <size-feature> ), and<size-feature>is defined as "the same as for a media feature: a feature name, a comparator, and a value". (Note that you do not always have a comparator, eg.orientation: portrait.)Besides, I assume that
media-progress(<media-feature>, ...)andcontainer-progress(<size-feature>, ...)are supposed to accept/take a query without using a()-block.