Skip to content

[css-view-transitions-2] Allow pseudo-element with class and no * #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[css-view-transitions-2] Allow pseudo-element with class and no * #10153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions css-view-transitions-2/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,17 +631,18 @@ div.box {
are extended to support the following syntax:

<pre class=prod>
::view-transition-group(<<pt-name-selector>><<pt-class-selector>>)
::view-transition-image-pair(<<pt-name-selector>><<pt-class-selector>>)
::view-transition-old(<<pt-name-selector>><<pt-class-selector>>)
::view-transition-new(<<pt-name-selector>><<pt-class-selector>>)
::view-transition-group(<<pt-name-and-class-selector>>)
::view-transition-image-pair(<<pt-name-and-class-selector>>)
::view-transition-old(<<pt-name-and-class-selector>>)
::view-transition-new(<<pt-name-and-class-selector>>)
</pre>

where <<pt-name-selector>> works as previously defined, and
<<pt-class-selector>> has the following syntax definition:
<<pt-name-and-class-selector>> has the following syntax definition:

<pre class=prod>
<dfn>&lt;pt-class-selector></dfn> = ['.' <<custom-ident>>]*
<dfn>&lt;pt-name-and-class-selector></dfn> = <<pt-name-selector>><<pt-class-selector>>? | <<pt-class-selector>>
Copy link
Member

@khushalsagar khushalsagar Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here "?" implies zero or more class selectors.

Copy link
Collaborator Author

@noamr noamr Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, zero or one <<pt-class-selector>>, which would be one or more (because it has +)

<dfn>&lt;pt-class-selector></dfn> = ['.' <<custom-ident>>]+
Copy link
Member

@khushalsagar khushalsagar Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming, the "+" means there needs to be at least 1 class.

Copy link
Collaborator Author

@noamr noamr Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

</pre>

A [=named view transition pseudo-element=] [=selector=] which has one or more <<custom-ident>> values
Expand Down