Skip to content

[cssom-view] add shadowRoots parameter to caretPositionFromPoint API. #10200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2024
Merged

[cssom-view] add shadowRoots parameter to caretPositionFromPoint API. #10200

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb7f6bb
Update Overview.bs
siliu1 Apr 4, 2024
b7ce1b5
Update Overview.bs
siliu1 Apr 16, 2024
745d1ee
Update Overview.bs
siliu1 Apr 17, 2024
5ad82d8
Update Overview.bs
siliu1 Apr 18, 2024
bd00fe8
Update Overview.bs
siliu1 Apr 19, 2024
548b0a0
Update Overview.bs
siliu1 Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions cssom-view-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ Note: Some non-conforming implementations are known to return 32 instead of 24.
partial interface Document {
Element? elementFromPoint(double x, double y);
sequence<Element> elementsFromPoint(double x, double y);
CaretPosition? caretPositionFromPoint(double x, double y);
CaretPosition? caretPositionFromPoint(double x, double y, ShadowRoot... shadowRoots);
readonly attribute Element? scrollingElement;
};
</pre>
Expand Down Expand Up @@ -1042,7 +1042,7 @@ instance, an element can be excluded from being a target for hit testing by usin
1. If the document has a [=root element=], and the last item in <var>sequence</var> is not the [=root element=], append the [=root element=] to <var>sequence</var>.
1. Return <var>sequence</var>.

The <dfn method for=Document>caretPositionFromPoint(<var>x</var>, <var>y</var>)</dfn> method must return the
The <dfn method for=Document>caretPositionFromPoint(<var>x</var>, <var>y</var>, ...<var>shadowRoots</var>)</dfn> method must return the
result of running these steps:

1. If there is no <a>viewport</a> associated with the document, return null.
Expand Down Expand Up @@ -1070,21 +1070,18 @@ result of running these steps:
<dt><a>caret range</a>
<dd>null
</dl>
1. Otherwise, return a <a>caret position</a> where the
<a>caret range</a> is a collapsed
{{Range}} object for the position
where the text insertion point indicator would have been inserted when applying the <a>transforms</a> that apply to the descendants of the
<a>viewport</a>, and the other properties are set as follows:

<dl>
<dt><a>caret node</a>
<dd>The [=range/start node=]
of the <a>caret range</a>.

<dt><a>caret offset</a>
<dd>The [=range/start offset=] of
the <a>caret range</a>.
</dl>
1. Otherwise:

1. Let <var>caretPosition</var> be a <a for=/>tuple</a> consisting of a <var>caretPositionNode</var> (a <a for=/>node</a>) and a <var>caretPositionOffset</var> (a non-negative integer) for the position where the text insertion point indicator would have been inserted when applying
the <a>transforms</a> that apply to the descendants of the <a>viewport</a>.
1. Let <var>startNode</var> be the <var>caretPositionNode</var> of the <var>caretPosition</var>, and let <var>startOffset</var> be the <var>caretPositionOffset</var> of the <var>caretPosition</var>.
1. While <var>startNode</var> is a [=node=], <var>startNode</var>'s [=tree/root=] is a [=shadow root=], and <var>startNode</var>'s [=tree/root=] is not a [=shadow-including inclusive ancestor=] of any of <var>shadowRoots</var>, repeat these steps:
1. Set <var>startOffset</var> to [=tree/index=] of <var>startNode</var>'s [=tree/root=]'s [=host=].
1. Set <var>startNode</var> to <var>startNode</var>'s [=tree/root=]'s [=host=]'s [=tree/parent=].</li>
1. Return a <a>caret position</a> with its properties set as follows:
1. <a>caret node</a> is set to <var>startNode</var>.
1. <a>caret offset</a> is set to <var>startOffset</var>.
1. <a>caret range</a> is set to a collapsed {{Range}} object which [=range/start node=] and [=range/end node=] are <var>startNode</var>, and which [=range/start offset=] and [=range/end offset=] are <var>startOffset</var>.

Note: The specifics of hit testing are out of scope of this
specification and therefore the exact details of
Expand Down Expand Up @@ -1148,6 +1145,8 @@ aborting on the first step that returns a value:

Note: This {{DOMRect}} object is not <a spec=html>live</a>.

Issue(10230): Consider removing <a>caret range</a> concept from <dfn>caret position</dfn> interface.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a build error fwiw. caret position is defined twice.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for that in #10285


<h2 id=extension-to-the-element-interface caniuse="element-scroll-methods">
Extensions to the {{Element}} Interface</h2>

Expand Down