Skip to content

Conversation

@DavMila
Copy link
Contributor

@DavMila DavMila commented Apr 18, 2024

This adds details to the scroll-snap-2 spec[1] to specify scroll-start-target.

[1] https://drafts.csswg.org/css-scroll-snap-2

This adds details to the scroll-snap-2 spec[1] to specify
scroll-start-target.

[1] https://drafts.csswg.org/css-scroll-snap-2
@DavMila DavMila requested a review from flackr April 18, 2024 18:09
Copy link
Contributor Author

@DavMila DavMila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggested changes, ptal, thanks.

@DavMila DavMila requested a review from flackr April 26, 2024 15:13
David Awogbemila added 2 commits May 16, 2024 10:52
Define initial scroll position precedence in css-overflow-3.
De-vaguify post-first layout scroll-start-target & point to document
update process.
Extract scroll-view position algorithm for standalone use.
@DavMila DavMila requested a review from flackr May 16, 2024 15:08
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, I think this is looking good, and extracting the algorithm to calculate the position that would scroll into view will be really useful for other spec changes coming.

David Awogbemila and others added 2 commits June 4, 2024 09:53
Replace scroll-view with scroll-into-view.
Mention and link css properties that change initial scroll position.
@DavMila DavMila self-assigned this Jun 4, 2024
@DavMila DavMila requested a review from tabatkins June 4, 2024 14:06
@tabatkins tabatkins merged commit 2c40247 into w3c:main Jun 21, 2024
cdoublev added a commit to cdoublev/csswg-drafts that referenced this pull request Jun 26, 2024
- removed "3.2.2. The scroll-start-target shorthand" and moved up its content (the property definition table)
- removed remnants of `scroll-start-target-*` longhands (removed in w3c#10227)
@DavMila DavMila deleted the scroll-start-target branch June 26, 2024 14:11
cdoublev added a commit to cdoublev/csswg-drafts that referenced this pull request Jun 26, 2024
- removed "3.2.2. The scroll-start-target shorthand" and moved up its content (the property definition table)
- removed remnants of `scroll-start-target-*` longhands (removed in w3c#10227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants