Skip to content

[css-view-transitions-1] Fix timing of resolving "update callback done" promise #10302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

[css-view-transitions-1] Fix timing of resolving "update callback done" promise #10302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions css-view-transitions-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,8 +1280,6 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
If failure is returned, then [=skip the view transition=] for |transition| with an "{{InvalidStateError}}" {{DOMException}} in |transition|'s [=relevant Realm=],
and return.

1. [=Resolve=] |transition|'s [=ViewTransition/update callback done promise=] with undefined.

1. [=list/For each=] |capturedElement| of |transition|'s [=ViewTransition/named elements=]' [=map/values=]:

1. If |capturedElement|'s [=captured element/new element=] is not null,
Expand Down Expand Up @@ -1599,11 +1597,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
1. If |transition|'s [=ViewTransition/phase=] is not "`done`", then set |transition|'s [=ViewTransition/phase=] to "`update-callback-called`".

1. Let |fulfillSteps| be to following steps:
1. [=Activate view transition|Activate=] |transition|.

1. [=Resolve=] |transition|'s [=ViewTransition/update callback done promise=] with undefined.

Note: This would be a no-op if the previous step already resolved the promise.
1. [=Activate view transition|Activate=] |transition|.

1. Let |rejectSteps| be the following steps given |reason|:
1. [=Reject=] |transition|'s [=ViewTransition/update callback done promise=] with |reason|.
Expand Down