[css-view-transitions-1] Ignore names from shadow DOM #10306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
reviewed
May 13, 2024
webkit-commit-queue
pushed a commit
to nt1m/WebKit
that referenced
this pull request
May 13, 2024
https://bugs.webkit.org/show_bug.cgi?id=273883 rdar://127995859 Reviewed by Antti Koivisto. Corresponding spec issue: w3c/csswg-drafts#10145 Corresponding spec PR: w3c/csswg-drafts#10306 This ignores view-transition names from shadow DOM, given the pseudo-elements are linked to the document element, exposing shadow DOM names to the view transition pseudo-elements would be a violation of shadow DOM principles. We don't check for the tree scope directly in `forEachRendererInPaintOrder` because a shadow DOM element might have flat tree descendants that have an outer tree scope. We also use the `Styleable`'s element instead of `RenderElement`'s element because for pseudo-elements we want to consider the associated element's tree scope. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::captureNewState): Canonical link: https://commits.webkit.org/278704@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies resolution at #10145.